Skip to content

head: remove Default trait from HeadOptions#12261

Open
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:head_remove_default
Open

head: remove Default trait from HeadOptions#12261
cakebaker wants to merge 1 commit into
uutils:mainfrom
cakebaker:head_remove_default

Conversation

@cakebaker

Copy link
Copy Markdown
Contributor

I noticed that we use let mut options = Self::default(); in the constructor of HeadOptions, followed by setting all of its properties again. This PR simplifies the constructor and removes the Default trait from HeadOptions.

@cakebaker
cakebaker force-pushed the head_remove_default branch from 7ea912e to a715a8e Compare May 12, 2026 14:39
@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/retry (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@sylvestre
sylvestre force-pushed the head_remove_default branch from a715a8e to cea57ef Compare June 7, 2026 20:58
@cakebaker
cakebaker force-pushed the head_remove_default branch from cea57ef to 8b2f687 Compare July 21, 2026 08:57
@cakebaker

Copy link
Copy Markdown
Contributor Author

Changes since last push:

  • rebased and fixed conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant