Skip to content

wc: remove splice_exact#12316

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:wc-splice-exact
Open

wc: remove splice_exact#12316
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:wc-splice-exact

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 15, 2026

Usage of splice_exact is valid for wc -c because it just discards input. But I want to remove it since it has dangerous interface. See #12315 (comment) .

[Edit] mitigate condition we continue splice loop.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will not alter performance

✅ 319 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing oech3:wc-splice-exact (bcc8fbd) with main (4da1068)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout-group (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/tail/pipe-f is now passing!
Note: The gnu test tests/env/env-signal-handler was skipped on 'main' but is now failing.

@oech3 oech3 marked this pull request as ready for review May 16, 2026 01:21
@oech3 oech3 force-pushed the wc-splice-exact branch 2 times, most recently from 87a9e09 to 12678c7 Compare May 19, 2026 09:37
@oech3 oech3 force-pushed the wc-splice-exact branch from 12678c7 to bcc8fbd Compare May 19, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant