more: swap -f and -l short flags to match GNU/util-linux#12337
Open
c-tonneslan wants to merge 1 commit into
Open
more: swap -f and -l short flags to match GNU/util-linux#12337c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
The clap definition had -l mapped to --logical and -f mapped to
--no-pause, which is the reverse of how util-linux more works. The
help strings on each long option were also describing the other one,
so the only thing that was internally consistent was the long names.
Real more:
-f, --logical Count logical lines, rather than screen lines
-l, --no-pause Suppress pausing after form feed (^L)
Fix the short flag assignments and the en-US/fr-FR help strings.
Both options are still no-ops behavior-wise (still marked as
unimplemented), but at least the CLI surface is right.
For uutils#2320.
Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clap definition had
-lmapped to--logicaland-fmapped to--no-pause, which is the reverse of util-linuxmore. The help strings were also describing the wrong long option, so the only thing that was internally consistent was the long names.util-linux
more:Swapped the short flags and the en-US/fr-FR help strings. Both options are still no-ops (the struct fields are still prefixed with
_and markednot implemented), but at least the CLI surface is right now and--helpdoesn't describe the wrong behavior.For #2320.