Skip to content

id: don't exit 1 when uid/gid name lookup fails in default output #12341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c-tonneslan wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Open

id: don't exit 1 when uid/gid name lookup fails in default output #12341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/uu/id/src/id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,10 @@ fn id_print(state: &State, groups: &[u32]) -> io::Result<()> {

let mut lock = io::stdout().lock();

// Name lookup failures in the default output are non-fatal: GNU `id`
// happily prints just the numeric id and exits 0. Docker containers
// routinely run as uids that don't have a /etc/passwd entry, and exit
// 1 here breaks init scripts that probe with `id`.
write!(
lock,
"uid={uid}({})",
Expand All @@ -646,7 +650,6 @@ fn id_print(state: &State, groups: &[u32]) -> io::Result<()> {
"{}",
translate!("id-error-cannot-find-user-name", "uid" => uid)
);
set_exit_code(1);
uid.to_string()
})
)?;
Expand All @@ -658,7 +661,6 @@ fn id_print(state: &State, groups: &[u32]) -> io::Result<()> {
"{}",
translate!("id-error-cannot-find-group-name", "gid" => gid)
);
set_exit_code(1);
gid.to_string()
})
)?;
Expand All @@ -671,7 +673,6 @@ fn id_print(state: &State, groups: &[u32]) -> io::Result<()> {
"{}",
translate!("id-error-cannot-find-user-name", "uid" => euid)
);
set_exit_code(1);
euid.to_string()
})
)?;
Expand All @@ -686,7 +687,6 @@ fn id_print(state: &State, groups: &[u32]) -> io::Result<()> {
"{}",
translate!("id-error-cannot-find-group-name", "gid" => egid)
);
set_exit_code(1);
egid.to_string()
})
)?;
Expand All @@ -703,7 +703,6 @@ fn id_print(state: &State, groups: &[u32]) -> io::Result<()> {
"{}",
translate!("id-error-cannot-find-group-name", "gid" => gr)
);
set_exit_code(1);
gr.to_string()
})
))
Expand Down