refactor: replace rustix::pipe with std::io::pipe#12356
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
oech3
reviewed
May 18, 2026
oech3
reviewed
May 18, 2026
|
GNU testsuite comparison: |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
xtqqczze
commented
May 18, 2026
f533322 to
70f20be
Compare
Contributor
|
I noticed that |
oech3
reviewed
May 18, 2026
oech3
reviewed
May 18, 2026
Contributor
|
I agree with some names of vars are not ideal, but I don't think we need to hurry generating many confliction. |
Contributor
Author
Contributor
|
Thanks. |
Contributor
|
d13ff2c to
3aad789
Compare
Contributor
|
Any std replacement for https://doc.servo.org/rustix/pipe/constant.PIPE_BUF.html ? |
Contributor
Author
Contributor
|
Thanks to both of you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::io::pipeprovidesPipeReaderandPipeWritertypes, wrappers around the underlying pipe file descriptors/handles that implement theReadandWritetraits respectively. This removes the directrustixdependency while preserving existing behavior.