Skip to content

uucore: upgrade md-5, sha1, sha2, sha3, digest to latest versions#12367

Merged
cakebaker merged 1 commit into
uutils:mainfrom
gabrielhnf:update-digest-dependent-crates
May 19, 2026
Merged

uucore: upgrade md-5, sha1, sha2, sha3, digest to latest versions#12367
cakebaker merged 1 commit into
uutils:mainfrom
gabrielhnf:update-digest-dependent-crates

Conversation

@gabrielhnf
Copy link
Copy Markdown
Contributor

@gabrielhnf gabrielhnf commented May 18, 2026

Fixes #12361

Upgrades the hash-related crates to their latest versions

  • Bumped md-5 to 0.11.0, sha1 to 0.11.0, sha2 to 0.11.0, sha3 to 0.12.0, digest to 0.11.0
  • Added shake 0.1.0 since Shake128/Shake256 were moved out of sha3 into a separate crate in 0.12.0
  • Updated impl_digest_common to use finalize_reset instead of finalize_into_reset, as that was one of the breaking changes

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/misc/io-errors (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/retry (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 19, 2026

Merging this PR will not alter performance

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
❌ 4 regressed benchmarks
✅ 312 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cksum_sha224 1.8 s 1.6 s +10.54%
Simulation cksum_sha3 1.8 s 1.9 s -3.39%
Simulation cksum_shake256 1.9 s 1.9 s -3.31%
Simulation cksum_sha2 1.8 s 1.6 s +10.54%
Simulation cksum_shake128 1.5 s 1.6 s -3.29%
Simulation cksum_sha256 1.8 s 1.6 s +10.54%
Simulation cksum_md5 320.9 ms 335.1 ms -4.22%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing gabrielhnf:update-digest-dependent-crates (3a9e69c) with main (f28d828)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@xtqqczze

This comment was marked as outdated.

@xtqqczze

This comment was marked as resolved.

@xtqqczze

This comment was marked as resolved.

Comment thread Cargo.toml Outdated
sm3 = "0.5.0"
crc-fast = { version = "1.5.0", default-features = false }
digest = "0.10.7"
crc-fast = { version = "1.10.0", default-features = false }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since crc-fast still depends on digest v0.10.7, could you please revert the bump to 1.10.0, along with the MSRV increase?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgrading crc-fast to 1.5.0 makes cargo resolve it as 1.9.0 with cargo update. Is this acceptable?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is fine. Cargo.toml specifies the minimum compatible version, so if cargo update resolves crc-fast to 1.9.0, that’s expected and acceptable.

@gabrielhnf gabrielhnf force-pushed the update-digest-dependent-crates branch from 444b2e4 to 3a9e69c Compare May 19, 2026 13:22
@xtqqczze

This comment was marked as resolved.

@cakebaker cakebaker merged commit 1878270 into uutils:main May 19, 2026
172 of 174 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade crates that depend on digest

3 participants