uucore: upgrade md-5, sha1, sha2, sha3, digest to latest versions#12367
Conversation
|
GNU testsuite comparison: |
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | cksum_sha224 |
1.8 s | 1.6 s | +10.54% |
| ❌ | Simulation | cksum_sha3 |
1.8 s | 1.9 s | -3.39% |
| ❌ | Simulation | cksum_shake256 |
1.9 s | 1.9 s | -3.31% |
| ⚡ | Simulation | cksum_sha2 |
1.8 s | 1.6 s | +10.54% |
| ❌ | Simulation | cksum_shake128 |
1.5 s | 1.6 s | -3.29% |
| ⚡ | Simulation | cksum_sha256 |
1.8 s | 1.6 s | +10.54% |
| ❌ | Simulation | cksum_md5 |
320.9 ms | 335.1 ms | -4.22% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing gabrielhnf:update-digest-dependent-crates (3a9e69c) with main (f28d828)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
| sm3 = "0.5.0" | ||
| crc-fast = { version = "1.5.0", default-features = false } | ||
| digest = "0.10.7" | ||
| crc-fast = { version = "1.10.0", default-features = false } |
There was a problem hiding this comment.
Since crc-fast still depends on digest v0.10.7, could you please revert the bump to 1.10.0, along with the MSRV increase?
There was a problem hiding this comment.
Downgrading crc-fast to 1.5.0 makes cargo resolve it as 1.9.0 with cargo update. Is this acceptable?
There was a problem hiding this comment.
Yes, this is fine. Cargo.toml specifies the minimum compatible version, so if cargo update resolves crc-fast to 1.9.0, that’s expected and acceptable.
444b2e4 to
3a9e69c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Thanks for your PR! |
Fixes #12361
Upgrades the hash-related crates to their latest versions
md-5to 0.11.0,sha1to 0.11.0,sha2to 0.11.0,sha3to 0.12.0,digestto 0.11.0shake0.1.0 sinceShake128/Shake256were moved out ofsha3into a separate crate in 0.12.0impl_digest_commonto usefinalize_resetinstead offinalize_into_reset, as that was one of the breaking changes