Skip to content

feat(sum): use larger buffer in bsd_sum and sysv_sum#12391

Merged
cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:sum-buf-size
May 20, 2026
Merged

feat(sum): use larger buffer in bsd_sum and sysv_sum#12391
cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:sum-buf-size

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented May 19, 2026

Follow-up #3741

Increase stack buffer size from 4 KiB to 8 KiB.

$ hyperfine --warmup 1 "time ./target/release/sum wikidatawiki-20251220-pages-logging.xml" "time ./target/release/sum.ref wikidatawiki-20251220-pages-logging.xml"
Benchmark 1: time ./target/release/sum wikidatawiki-20251220-pages-logging.xml
  Time (mean ± σ):     12.819 s ±  0.012 s    [User: 8.082 s, System: 2.085 s]
  Range (min … max):   12.807 s … 12.845 s    10 runs
 
Benchmark 2: time ./target/release/sum.ref wikidatawiki-20251220-pages-logging.xml
  Time (mean ± σ):     13.085 s ±  0.022 s    [User: 8.138 s, System: 2.290 s]
  Range (min … max):   13.065 s … 13.142 s    10 runs
 
Summary
  time ./target/release/sum wikidatawiki-20251220-pages-logging.xml ran
    1.02 ± 0.00 times faster than time ./target/release/sum.ref wikidatawiki-20251220-pages-logging.xml

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/tail-n0f is now passing!

@xtqqczze xtqqczze marked this pull request as ready for review May 19, 2026 20:02
@cakebaker cakebaker merged commit 471c68d into uutils:main May 20, 2026
173 checks passed
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks!

@xtqqczze xtqqczze deleted the sum-buf-size branch May 20, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants