fix install file with invalid uid#7789
Conversation
|
Could you please add a test to make sure we don't regress? Thanks |
fa60b65 to
65d1bb6
Compare
Finished the test. |
65d1bb6 to
f87aa34
Compare
|
GNU testsuite comparison: |
961eec9 to
2dd5646
Compare
|
GNU testsuite comparison: |
2dd5646 to
6d1e62c
Compare
|
GNU testsuite comparison: |
6d1e62c to
76477ee
Compare
|
GNU testsuite comparison: |
76477ee to
33830bb
Compare
|
GNU testsuite comparison: |
33830bb to
054dc17
Compare
|
many jobs are failing |
|
GNU testsuite comparison: |
054dc17 to
dde3ee9
Compare
|
GNU testsuite comparison: |
Caused by some rebase issues, fixed it now. By the way, the test in this PR need to ensure that there's no user with userid 500 on the system, maybe I can modify the userid in the prepare stage of CICD runners? |
|
I don't think you need to configure the system, you can just avoid hardcoding 500 and instead use the first UID not in |
dde3ee9 to
ee47432
Compare
I'm using a long script to get a uid not in /etc/passwd, so adding subprocess to use the Exec::shell method. |
74b9db7 to
9f73173
Compare
|
GNU testsuite comparison: |
b4907d9 to
3eca983
Compare
|
GNU testsuite comparison: |
3eca983 to
7c58a44
Compare
|
GNU testsuite comparison: |
7c58a44 to
e7b56c7
Compare
|
GNU testsuite comparison: |
e7b56c7 to
16c5c50
Compare
|
GNU testsuite comparison: |
53dde80 to
d28c379
Compare
|
GNU testsuite comparison: |
|
Hi, i just rebased the fix branch with the main branch, and all tests passed. Thanks for your time. |
|
Are you sure? on my system: |
The manpage says the owner option of install is for super-user only, maybe we need to test this option with the root user. |
d28c379 to
517fb30
Compare
|
GNU testsuite comparison: |
88d0778 to
8a04391
Compare
|
GNU testsuite comparison: |
8a04391 to
f705452
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
6d3602e to
21b75da
Compare
|
GNU testsuite comparison: |
21b75da to
20ce4e0
Compare
|
GNU testsuite comparison: |
20ce4e0 to
8c19054
Compare
|
GNU testsuite comparison: |
fixes #7879