GNUMakefile: fix compilation on Macs#7964
Conversation
ec94710 to
ec95e76
Compare
|
could you please add a job in the CI to make sure we don't regress ? |
|
There's a Mac ARM build in there already, and it's passing on main/master. So I would need to find the difference between the Mac ARM build in CI, and my Mac. I'm not sure the best way to do that. |
|
Ah - the CICD sets the And we can make CICD reproduce my failing build by removing the I don't know, it feels a bit duplicative to have to set that flag explicitly. |
|
GNU testsuite comparison: |
|
@kevinburke can you check if the |
|
Now that you found the culprit, could you please extend the ci to the test this combination? Thanks |
Previously, attempting to compile on Macs would bring in the SELinux dependencies (runcon) which led to compilation errors on Macs. Fixes uutils#7695.
ec95e76 to
2408bd6
Compare
|
@sylvestre here is that commit, it is the only commit that does not have a "features" tag - kevinburke@24ff36ee8 I'm still a bit confused - isn't there something that can set default "features" based on the compilation architecture, and then you can override it if need be. |
|
@kpcyrd I can compile on Mac with no problems if I remove this patch and apply your patch. |
|
GNU testsuite comparison: |
Previously, attempting to compile on Macs would bring in the SELinux dependencies (runcon) which led to compilation errors on Macs.
Fixes #7695.