util/build-gnu.sh: Bypass timeout/yes SIGPIPE handling bug#8353
Merged
cakebaker merged 1 commit intouutils:mainfrom Jul 22, 2025
Merged
util/build-gnu.sh: Bypass timeout/yes SIGPIPE handling bug#8353cakebaker merged 1 commit intouutils:mainfrom
cakebaker merged 1 commit intouutils:mainfrom
Conversation
See uutils#7252, both `timeout` and `yes` reset the SIGPIPE handler (actually, the Rust core does that), leading to trap_sigpipe_or_skip_ test: ``` (trap '' PIPE && timeout 10 yes |:) 2>&1 | grep 'Broken pipe' ``` to fail, causing 4 tests to be skipped. I believe the intent here is to check if the OS supports SIGPIPE, so it probably makes sense to use System's timeout/yes here, and run the tests anyway (which, happen to pass).
|
GNU testsuite comparison: |
Collaborator
Author
|
Weird, those 4 GNUtest failure didn't happen for me. I cleaned up my local This is ok BTW, it's more accurate to mark those tests as FAILed than SKIPed IMHO. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #7252, both
timeoutandyesreset the SIGPIPE handler (actually, the Rust core does that), leading to trap_sigpipe_or_skip_ test:to fail, causing 4 tests to be skipped.
I believe the intent here is to check if the OS supports SIGPIPE, so it probably makes sense to use System's timeout/yes here, and run the tests anyway (which, happen to pass).