tests/cp/preserve-gid: Partial fix#8380
Merged
RenjiSann merged 2 commits intouutils:mainfrom Jul 24, 2025
Merged
Conversation
Patching tests/local.mk instead of Makefile makes it a bit easier to see what has been modified with a `git diff`, and Makefile is generated anyway.
path_prepend_ sets $abs_path_dir_, but the sed command above removes it. Set it manually instead. Fixes part of tests/cp/preserve-gid.
|
GNU testsuite comparison: |
drinkcat
force-pushed
the
cp-preserve-gid
branch
from
1172148 to
58095fa
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for
tests/cp/preserve-gid, and also a small refactoring ofutil/build-gnu.sh.I'll file a bug for the next issue.
util/build-gnu.sh: Replace $abs_path_dir_
path_prepend_ sets $abs_path_dir_, but the sed command above removes
it. Set it manually instead.
Fixes part of tests/cp/preserve-gid.
util/build.sh: Patch tests/local.mk instead of Makefile
Patching tests/local.mk instead of Makefile makes it a bit easier
to see what has been modified with a
git diff, and Makefileis generated anyway.