Skip to content

Cargo.toml: remove two features #8954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 2 commits into from
Oct 19, 2025
Merged

Cargo.toml: remove two features #8954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14ba196
Cargo.toml: remove "test_unimplemented" feature
cakebaker Oct 19, 2025
45e1404
Cargo.toml: remove unused "nightly" feature
cakebaker Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ macos = ["feat_os_macos"]
unix = ["feat_os_unix"]
windows = ["feat_os_windows"]
## project-specific feature shortcodes
nightly = []
test_unimplemented = []
expensive_tests = []
# "test_risky_names" == enable tests that create problematic file names (would make a network share inaccessible to Windows, breaks SVN on Mac OS, etc.)
test_risky_names = []
Expand Down
6 changes: 3 additions & 3 deletions tests/by-util/test_comm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ fn zero_terminated_with_total() {
}
}

#[cfg_attr(not(feature = "test_unimplemented"), ignore = "")]
#[ignore = "not implemented"]
#[test]
fn check_order() {
let scene = TestScenario::new(util_name!());
Expand All @@ -324,7 +324,7 @@ fn check_order() {
.stderr_is("error to be defined");
}

#[cfg_attr(not(feature = "test_unimplemented"), ignore = "")]
#[ignore = "not implemented"]
#[test]
fn nocheck_order() {
let scene = TestScenario::new(util_name!());
Expand All @@ -340,7 +340,7 @@ fn nocheck_order() {
// when neither --check-order nor --no-check-order is provided,
// stderr and the error code behaves like check order, but stdout
// behaves like nocheck_order. However with some quirks detailed below.
#[cfg_attr(not(feature = "test_unimplemented"), ignore = "")]
#[ignore = "not implemented"]
#[test]
fn defaultcheck_order() {
let scene = TestScenario::new(util_name!());
Expand Down
Loading