Skip to content

GNUmakefile: Add a value for cross-build#9015

Merged
sylvestre merged 9 commits into
uutils:mainfrom
oech3:cross
Oct 26, 2025
Merged

GNUmakefile: Add a value for cross-build#9015
sylvestre merged 9 commits into
uutils:mainfrom
oech3:cross

Conversation

@oech3

@oech3 oech3 commented Oct 25, 2025

Copy link
Copy Markdown
Contributor

uudoc needs different build RUSTFLAGS for cross-build.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@sylvestre

Copy link
Copy Markdown
Contributor

Could you please add a test in github action to make sure we don't regress in the future?

@oech3

This comment was marked as resolved.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@oech3

oech3 commented Oct 25, 2025

Copy link
Copy Markdown
Contributor Author

@Ecordonnier I don't know pkg names of Ubuntu well. Needs your help.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@sylvestre

Copy link
Copy Markdown
Contributor

you are mixing changes {} => () and the rest of the change
could you please rewrite the stack to have commits doing one change

@oech3 oech3 changed the title GNUmakefile: Fix cross-build GNUmakefile: Add a velue for cross-build Oct 26, 2025
@oech3 oech3 changed the title GNUmakefile: Add a velue for cross-build GNUmakefile: Add a value for cross-build Oct 26, 2025
@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 552c386 into uutils:main Oct 26, 2025
121 checks passed
@oech3 oech3 deleted the cross branch October 26, 2025 13:39
@Ecordonnier

Copy link
Copy Markdown
Collaborator

Can't you just remove CARGOFLAGS from the call which is building uudocs instead of adding a new variable for the target? I would expect that those CARGOFLAGS would be for the target build, not for tools which are compiled for the host architecture.

@oech3

oech3 commented Oct 27, 2025

Copy link
Copy Markdown
Contributor Author

Can't you just remove CARGOFLAGS from the call which is building uudocs instead of adding a new variable for the target?

No. Because it would block reusing prebuilt crate caches from coreutils (at non-cross build).

@oech3

oech3 commented Oct 27, 2025

Copy link
Copy Markdown
Contributor Author

Because it would block reusing prebuilt crate caches from coreutils

@aaron-ang Is uudoc changed by feat_selinux or feat_systemd_logind and removing them cause double build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants