CICD.yml: Remove a test causing confliction#9286
Conversation
CodSpeed Performance ReportMerging #9286 will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
| if [ -z "${{ matrix.job.features }}" ]; then ARTIFACTS_SUFFIX='-nofeatures' ; fi | ||
| outputs CARGO_CMD | ||
| outputs CARGO_CMD_OPTIONS | ||
| outputs ARTIFACTS_SUFFIX |
There was a problem hiding this comment.
| outputs ARTIFACTS_SUFFIX | |
| # package name (must be set after ARTIFACTS_SUFFIX is determined) | |
| PKG_suffix=".tar.gz" ; case '${{ matrix.job.target }}' in *-pc-windows-*) PKG_suffix=".zip" ;; esac; | |
| PKG_BASENAME=${PROJECT_NAME}-${REF_TAG:-$REF_SHAS}-${{ matrix.job.target }}${ARTIFACTS_SUFFIX} | |
| PKG_NAME=${PKG_BASENAME}${PKG_suffix} | |
| outputs PKG_suffix PKG_BASENAME PKG_NAME |
There was a problem hiding this comment.
before
PKG_BASENAME=${PROJECT_NAME}-${REF_TAG:-$REF_SHAS}-${{ matrix.job.target }}
after
PKG_BASENAME=${PROJECT_NAME}-${REF_TAG:-$REF_SHAS}-${{ matrix.job.target }}${ARTIFACTS_SUFFIX}
Now the release assets will have unique names:
- coreutils-0.3.0-x86_64-unknown-linux-gnu.tar.gz (use-cross version)
- coreutils-0.3.0-x86_64-unknown-linux-gnu-nocross.tar.gz (no-cross version)
- coreutils-0.3.0-aarch64-apple-darwin-nocross.tar.gz (with features)
- coreutils-0.3.0-aarch64-apple-darwin-nofeatures.tar.gz (without features)
There was a problem hiding this comment.
Can no we just drop one for simplity?
There was a problem hiding this comment.
Changeing download URL could break downstream's binary packages. I want to avoid it if possible.
Is cross version still useful?
|
At least, the test I tried to remove by this PR is covered by coreutils/.github/workflows/CICD.yml Lines 1264 to 1270 in 5202ac1 |
|
GNU testsuite comparison: |
|
Sorry, I can’t help you much right now. This needs to be debugged on the CI, and since you’ve already got a PR open and it’s running, I don’t want to pile on and stress our infrastructure :v |
|
OK. thankyou. |
|
Replaced by #9491 |
Preliminary for #9037 . Since we have tests for
*constubs, #7964 seems no longer needed.