rm: fix gnu coreutils test one-file-system.sh by mattsu2020 · Pull Request #9428 · uutils/coreutils

mattsu2020 · 2025-11-20T23:47:49Z

Summary

Remove the extra leading rm: from the rm-error-preserve-root-all locale strings so the message matches expected test output.
Keep wording otherwise unchanged across en-US and fr-FR locales.

#9127

github-actions · 2025-11-21T00:10:42Z

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions · 2025-11-21T23:54:03Z

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions · 2025-11-22T09:48:26Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions · 2025-12-01T13:51:42Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions · 2025-12-02T12:22:13Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/rm/one-file-system is no longer failing!

codspeed-hq · 2025-12-15T12:21:48Z

CodSpeed Performance Report

Merging #9428 will not alter performance

_{Comparing mattsu2020:rm_compatibility (1f09776) with main (1eea517)}

Summary

✅ 136 untouched
⏩ 24 skipped¹

24 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-12-15T12:25:15Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions · 2025-12-24T12:16:27Z

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!

sylvestre · 2025-12-27T10:22:23Z

i see 3 conflicts

github-actions · 2025-12-27T10:54:38Z

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions · 2025-12-27T11:21:13Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/one-file-system is no longer failing!
Congrats! The gnu test tests/tail/follow-name is no longer failing!

github-actions · 2025-12-27T11:42:27Z

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions · 2025-12-27T12:24:36Z

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions · 2025-12-27T13:00:20Z

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions · 2025-12-29T02:15:03Z

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions · 2025-12-31T01:14:37Z

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!
Congrats! The gnu test tests/tty/tty-eof is no longer failing!

github-actions · 2025-12-31T02:40:20Z

GNU testsuite comparison:

Congrats! The gnu test tests/tty/tty-eof is no longer failing!

github-actions · 2025-12-31T03:02:32Z

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions · 2026-01-01T06:11:51Z

GNU testsuite comparison:

Congrats! The gnu test tests/rm/one-file-system is no longer failing!

github-actions · 2026-01-01T07:01:57Z

GNU testsuite comparison:

GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/rm/one-file-system is no longer failing!

Add "tmpfs" to the spell-checker ignore comment in test_rm.rs to suppress warnings for this filesystem type term used in the tests.

…e_root_all - Changed preserve_root_all to retrieve device ID from parent directory's symlink metadata instead of file's metadata - Maintains one_fs option using file's metadata - Improves accuracy for preserving root directory across filesystems on Unix systems

…unction Remove the cfg-specific `should_skip_different_device` wrapper and directly call `should_skip_different_device_with_dev` with a `#[cfg(unix)]` attribute in the recursive directory removal function, reducing code duplication and improving clarity.

Remove wrapper functions `remove_dir_recursive` and `remove_dir_recursive_with_parent`, and inline conditional compilation directly in `handle_dir_impl` to reduce code duplication and improve maintainability without altering functionality.

Add conditional compilation to discard `parent_dev_id` parameter when not on Unix, preventing compiler warnings since this parameter is unused outside Unix-specific code paths.

sylvestre reviewed Nov 21, 2025

View reviewed changes

Comment thread src/uu/rm/locales/en-US.ftl

sylvestre reviewed Nov 21, 2025

View reviewed changes

Comment thread tests/by-util/test_rm.rs Outdated

sylvestre reviewed Nov 22, 2025

View reviewed changes

Comment thread src/uu/rm/src/rm.rs Outdated

sylvestre reviewed Dec 26, 2025

View reviewed changes

Comment thread src/uu/rm/src/rm.rs

sylvestre reviewed Dec 26, 2025

View reviewed changes

Comment thread src/uu/rm/src/rm.rs Outdated

sylvestre reviewed Dec 26, 2025

View reviewed changes

Comment thread src/uu/rm/src/rm.rs Outdated

sylvestre reviewed Dec 26, 2025

View reviewed changes

Comment thread src/uu/rm/src/platform/linux.rs Outdated

sylvestre reviewed Dec 30, 2025

View reviewed changes

Comment thread src/uu/date/src/locale.rs Outdated

sylvestre reviewed Dec 30, 2025

View reviewed changes

Comment thread src/uucore/src/lib/features/uptime.rs Outdated

mattsu2020 force-pushed the rm_compatibility branch from d8875f6 to 0da3869 Compare December 31, 2025 00:34

mattsu2020 marked this pull request as draft December 31, 2025 00:35

mattsu2020 force-pushed the rm_compatibility branch from 0da3869 to fe51531 Compare December 31, 2025 02:19

mattsu2020 marked this pull request as ready for review December 31, 2025 03:22

sylvestre reviewed Dec 31, 2025

View reviewed changes

Comment thread src/uu/rm/src/rm.rs Outdated

sylvestre reviewed Dec 31, 2025

View reviewed changes

Comment thread src/uu/rm/src/rm.rs Outdated

sylvestre reviewed Dec 31, 2025

View reviewed changes

Comment thread src/uu/rm/src/rm.rs Outdated

sylvestre reviewed Dec 31, 2025

View reviewed changes

Comment thread src/uu/rm/src/rm.rs Outdated

mattsu2020 requested a review from sylvestre January 5, 2026 10:38

mattsu2020 added 6 commits January 14, 2026 17:31

feat(rm): implement --one-file-system and --preserve-root=all

66f9647

chore(tests/rm): add tmpfs to spell-checker ignore list

aae07d3

Add "tmpfs" to the spell-checker ignore comment in test_rm.rs to suppress warnings for this filesystem type term used in the tests.

fix(rm): suppress unused parameter warning on non-Unix platforms

a57380d

Add conditional compilation to discard `parent_dev_id` parameter when not on Unix, preventing compiler warnings since this parameter is unused outside Unix-specific code paths.

mattsu2020 force-pushed the rm_compatibility branch from 1f09776 to a57380d Compare January 14, 2026 08:32

Merge branch 'main' into rm_compatibility

c8d623f

mattsu2020 marked this pull request as draft January 15, 2026 11:49

mattsu2020 closed this Jan 23, 2026

mattsu2020 deleted the rm_compatibility branch January 23, 2026 12:33

Uh oh!

Conversation

mattsu2020 commented Nov 20, 2025

Summary

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Nov 21, 2025

Uh oh!

Uh oh!

github-actions Bot commented Nov 22, 2025

Uh oh!

github-actions Bot commented Dec 1, 2025

Uh oh!

github-actions Bot commented Dec 2, 2025

Uh oh!

codspeed-hq Bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #9428 will not alter performance

Summary

Footnotes

Uh oh!

github-actions Bot commented Dec 15, 2025

Uh oh!

github-actions Bot commented Dec 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sylvestre commented Dec 27, 2025

Uh oh!

github-actions Bot commented Dec 27, 2025

Uh oh!

github-actions Bot commented Dec 27, 2025

Uh oh!

github-actions Bot commented Dec 27, 2025

Uh oh!

github-actions Bot commented Dec 27, 2025

Uh oh!

github-actions Bot commented Dec 27, 2025

Uh oh!

github-actions Bot commented Dec 29, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 31, 2025

Uh oh!

github-actions Bot commented Dec 31, 2025

Uh oh!

github-actions Bot commented Dec 31, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 1, 2026

Uh oh!

github-actions Bot commented Jan 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq Bot commented Dec 15, 2025 •

edited

Loading