cksum: symlink to md5sum,b2sum, and sha*sum by oech3 · Pull Request #9984 · uutils/coreutils

oech3 · 2026-01-02T12:46:36Z

Alt #9776 . but without individual bins.

codspeed-hq · 2026-01-02T12:54:26Z

CodSpeed Performance Report

Merging #9984 will improve performance by ×8,800

_{Comparing oech3:cksum-ln (a4c2c4f) with main (a4f6e1a)}

Summary

⚡ 14 improvements
✅ 125 untouched
⏩ 37 skipped¹

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`cksum_blake2b`	192,851.4 µs	208.6 µs	×920
⚡	`cksum_sha2`	1,727,099.3 µs	206.1 µs	×8,400
⚡	`cksum_crc`	16,990.8 µs	205.9 µs	×83
⚡	`cksum_sha1`	723,076.3 µs	206.1 µs	×3,500
⚡	`cksum_md5`	318,011.7 µs	206.2 µs	×1,500
⚡	`cksum_sha3`	1,828,114.8 µs	206.9 µs	×8,800
⚡	`cksum_sha512`	1,105,575.8 µs	207.2 µs	×5,300
⚡	`cksum_sha256`	1,727,122.1 µs	207.8 µs	×8,300
⚡	`cksum_bsd`	128,397.7 µs	206.2 µs	×620
⚡	`cksum_sha384`	1,105,538.7 µs	207.7 µs	×5,300
⚡	`cksum_sha224`	1,727,116.3 µs	207 µs	×8,300
⚡	`cksum_crc32b`	13,245.3 µs	207.2 µs	×64
⚡	`cksum_sysv`	48,258.8 µs	206.5 µs	×230
⚡	`cksum_sm3`	1,551,347.7 µs	205.8 µs	×7,500

37 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

oech3 · 2026-01-02T19:17:30Z

I considered that CodSpeed was broken, but it seems reproducible...

oech3 · 2026-01-02T19:36:35Z

cksum related GNU tests are passing.

oech3 · 2026-01-03T08:54:12Z

@naoNao89 Any idea about CodSpeed breakage?

oech3 · 2026-01-03T11:55:25Z

We should fix or remove #10002 before discarding hashsum.

naoNao89 · 2026-01-03T21:21:29Z

The file creation happens outside the benchmark loop, so the benchmarks are measuring almost nothing.

uu/cksum/benches/cksum_bench.rs:14-24

fn $algo_name(bencher: Bencher) {
    let data = text_data::generate_by_size(100, 80);
    let file_path = setup_test_file(&data);  // File created ONCE, outside loop
    
    bencher.bench(|| {
        black_box(run_util_function(
            uumain,
            &["--algorithm", $algo_str, file_path.to_str().unwrap()],
        ));
    });  // This loop only measures reading a cached file
}

I think we should:

generate fresh data inside the benchmark loop, or
clear file system caches between iterations, or
benchmark the hash computation directly without file I/O

github-actions · 2026-01-04T21:32:59Z

GNU testsuite comparison:

GNU test failed: tests/cksum/md5sum-bsd. tests/cksum/md5sum-bsd is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/shuf/shuf-reservoir. tests/shuf/shuf-reservoir is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-05T00:11:07Z

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-a. tests/cksum/cksum-a is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/md5sum-bsd. tests/cksum/md5sum-bsd is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-05T00:23:52Z

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-a. tests/cksum/cksum-a is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/md5sum-bsd. tests/cksum/md5sum-bsd is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-05T00:47:21Z

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-a. tests/cksum/cksum-a is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/md5sum-bsd. tests/cksum/md5sum-bsd is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-05T01:30:46Z

GNU testsuite comparison:

GNU test failed: tests/cksum/md5sum-bsd. tests/cksum/md5sum-bsd is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-05T02:56:56Z

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

oech3 · 2026-01-05T02:59:55Z

*sums are really bad legacy program :|

github-actions · 2026-01-05T03:12:28Z

GNU testsuite comparison:

GNU test failed: tests/cksum/md5sum-bsd. tests/cksum/md5sum-bsd is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/shuf/shuf-reservoir. tests/shuf/shuf-reservoir is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-05T05:30:04Z

GNU testsuite comparison:

GNU test failed: tests/cksum/b2sum. tests/cksum/b2sum is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/md5sum-bsd. tests/cksum/md5sum-bsd is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/md5sum-newline. tests/cksum/md5sum-newline is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/sha1sum. tests/cksum/sha1sum is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/sha1sum-vec. tests/cksum/sha1sum-vec is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/sha224sum. tests/cksum/sha224sum is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/sha256sum. tests/cksum/sha256sum is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/sha384sum. tests/cksum/sha384sum is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/cksum/sha512sum. tests/cksum/sha512sum is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-05T07:17:33Z

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-05T07:40:54Z

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

oech3 · 2026-01-05T08:47:33Z

@cakebaker @RenjiSann I made a symlink plan. I think we can make individual bins after hashsum deletion.
Should fix #10002 at 1st at least, and I'd like to merge clap related PRs to reduce size of a PR at both case (1 bin or N bins).

Failing test is uptime.

github-actions · 2026-01-05T11:13:51Z

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

oech3 · 2026-01-06T20:46:31Z

This looks very dangerous option if we don't have an extension --untagged on md5sum. Closing.

oech3 force-pushed the cksum-ln branch from 5b6ae78 to 0de1d4c Compare January 2, 2026 12:53

oech3 force-pushed the cksum-ln branch from 0de1d4c to cd06a9c Compare January 2, 2026 13:35

oech3 marked this pull request as ready for review January 2, 2026 13:36

oech3 force-pushed the cksum-ln branch 7 times, most recently from a79d274 to a132677 Compare January 2, 2026 18:41

cksum: symlink to md5sum,b2sum, and sha*sum

8f9ab45

oech3 force-pushed the cksum-ln branch from a132677 to 8f9ab45 Compare January 2, 2026 18:47

This was referenced Jan 2, 2026

hashsum: Drop flags for non GNU bins as covered by cksum -a --untagged #9797

Closed

cksum: Remove Some #10001

Closed

inconflict

3d88c4e

oech3 marked this pull request as draft January 3, 2026 11:55

oech3 marked this pull request as ready for review January 4, 2026 17:23

oech3 marked this pull request as draft January 4, 2026 17:23

Merge branch 'main' into cksum-ln

fcd31c4

oech3 force-pushed the cksum-ln branch 2 times, most recently from 4f404b2 to bc9fcbd Compare January 4, 2026 21:16

oech3 marked this pull request as ready for review January 4, 2026 21:53

oech3 force-pushed the cksum-ln branch from bc9fcbd to 55320ad Compare January 4, 2026 22:31

oech3 force-pushed the cksum-ln branch 2 times, most recently from 0aca569 to 39d9dad Compare January 5, 2026 00:00

oech3 force-pushed the cksum-ln branch from 2e9b653 to 6ff2449 Compare January 5, 2026 00:27

oech3 force-pushed the cksum-ln branch from 6ff2449 to fef0db1 Compare January 5, 2026 01:20

oech3 marked this pull request as draft January 5, 2026 02:31

oech3 force-pushed the cksum-ln branch from fef0db1 to a85619c Compare January 5, 2026 02:47

oech3 force-pushed the cksum-ln branch from a85619c to 4339cc7 Compare January 5, 2026 02:58

oech3 force-pushed the cksum-ln branch 2 times, most recently from f5d29b8 to ed07374 Compare January 5, 2026 05:18

oech3 force-pushed the cksum-ln branch 2 times, most recently from 044bb60 to de41913 Compare January 5, 2026 07:03

cksum: Minor improvement

944ea9a

oech3 force-pushed the cksum-ln branch 2 times, most recently from d5e6a80 to 944ea9a Compare January 5, 2026 07:30

oech3 marked this pull request as ready for review January 5, 2026 08:47

Merge branch 'main' into cksum-ln

a4c2c4f

oech3 closed this Jan 6, 2026

Uh oh!

Conversation

oech3 commented Jan 2, 2026

Uh oh!

codspeed-hq Bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #9984 will improve performance by ×8,800

Summary

Benchmarks breakdown

Footnotes

Uh oh!

oech3 commented Jan 2, 2026

Uh oh!

oech3 commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oech3 commented Jan 3, 2026

Uh oh!

oech3 commented Jan 3, 2026

Uh oh!

naoNao89 commented Jan 3, 2026

Uh oh!

github-actions Bot commented Jan 4, 2026

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

oech3 commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

oech3 commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 5, 2026

Uh oh!

oech3 commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq Bot commented Jan 2, 2026 •

edited

Loading

oech3 commented Jan 2, 2026 •

edited

Loading

oech3 commented Jan 5, 2026 •

edited

Loading

oech3 commented Jan 5, 2026 •

edited

Loading