reduce msrv to 1.70

Author: xtqqczze

.github/workflows/ci.yml

@@ -8,7 +8,7 @@ jobs:
     strategy:
       matrix:
         rust:
-          - 1.87.0
+          - 1.70.0
           - stable
           - nightly
         os: [ubuntu-latest, windows-latest, macos-latest]
@@ -30,7 +30,7 @@ jobs:
     strategy:
       matrix:
         rust:
-          - 1.87.0
+          - 1.70.0
           - stable
           - nightly
         os: [ubuntu-latest, windows-latest, macos-latest]

Cargo.lock

@@ -1,6 +1,6 @@
 [workspace.package]
 edition = "2018"
-rust-version = "1.87"
+rust-version = "1.70"
 
 [package]
 name = "num-prime"

Cargo.toml

@@ -427,7 +427,7 @@ impl NaiveBuffer {
     /// Legendre's phi function, used as a helper function for [`Self::prime_pi`]
     pub fn prime_phi(&mut self, x: u64, a: usize, cache: &mut LruCache<(u64, usize), u64>) -> u64 {
         if a == 1 {
-            return x.div_ceil(2);
+            return (x + 1) / 2;
         }
         if let Some(v) = cache.get(&(x, a)) {
             return *v;

src/buffer.rs

@@ -472,7 +472,7 @@ mod tests {
         let result = one_line(&n, n * 480, 100);
         assert!(result.0.is_some());
         let f = result.0.unwrap();
-        assert!(n.is_multiple_of(f) && f > 1 && f < n);
+        assert!(n % f == 0 && f > 1 && f < n);
     }
 
     // --- trial_division with limit=None (no limit path) ---
@@ -548,7 +548,7 @@ mod tests {
             for offset in [1u32, 2, 3, 5, 7] {
                 let (result, _) = pollard_rho(&target, start, offset, 10000);
                 if let Some(f) = result {
-                    assert!(target.is_multiple_of(f) && f > 1 && f < target);
+                    assert!(target % f == 0 && f > 1 && f < target);
                 }
             }
         }

src/factor.rs

@@ -115,7 +115,7 @@ impl ExactRoots for BigUint {
 
         // check mod 2
         let shift = self.trailing_zeros().unwrap();
-        if !shift.is_multiple_of(3) {
+        if shift % 3 != 0 {
             return None;
         }
 

src/integer.rs

@@ -62,6 +62,8 @@
 //!   could improve the speed of various functions with the cost of larger memory footprint.
 //!
 
+#![allow(clippy::redundant_clone)]
+
 pub mod buffer;
 pub mod factor;
 pub mod nt_funcs;

src/lib.rs

@@ -347,7 +347,7 @@ pub(crate) fn factorize64_advanced(cofactors: &[(u64, usize)]) -> Vec<(u64, usiz
             i += 1;
 
             // increase max iterations after trying all methods
-            if i.is_multiple_of(NMETHODS) {
+            if i % NMETHODS == 0 {
                 max_iter_ratio *= 2;
             }
         };
@@ -523,7 +523,7 @@ pub(crate) fn factorize128_advanced(cofactors: &[(u128, usize)]) -> Vec<(u128, u
             i += 1;
 
             // increase max iterations after trying all methods
-            if i.is_multiple_of(NMETHODS) {
+            if i % NMETHODS == 0 {
                 max_iter_ratio *= 2;
             }
         };
@@ -782,7 +782,7 @@ where
 pub fn moebius_factorized<T>(factors: &BTreeMap<T, usize>) -> i8 {
     if factors.values().any(|exp| exp > &1) {
         0
-    } else if factors.len().is_multiple_of(2) {
+    } else if factors.len() % 2 == 0 {
         1
     } else {
         -1