Skip to content

reduce msrv to 1.70#58

Merged
sylvestre merged 2 commits into
uutils:mainfrom
xtqqczze:msrv
Feb 20, 2026
Merged

reduce msrv to 1.70#58
sylvestre merged 2 commits into
uutils:mainfrom
xtqqczze:msrv

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Feb 20, 2026

Closes #34

cc: @sylvestre

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.89%. Comparing base (3f5db7d) to head (d5e2bf5).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   78.64%   84.89%   +6.25%     
==========================================
  Files          13       15       +2     
  Lines        2585     3410     +825     
  Branches      230      239       +9     
==========================================
+ Hits         2033     2895     +862     
+ Misses        552      515      -37     
Flag Coverage Δ
macos_latest 84.66% <100.00%> (+7.02%) ⬆️
ubuntu_latest 84.36% <100.00%> (+6.18%) ⬆️
windows_latest 17.82% <0.00%> (+3.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xtqqczze xtqqczze force-pushed the msrv branch 2 times, most recently from bd75ea9 to a13419f Compare February 20, 2026 02:22
@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented Feb 20, 2026

Merging this PR will degrade performance by 55.93%

❌ 1 regressed benchmark
✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation num-primes 19.2 ms 43.6 ms -55.93%

Comparing xtqqczze:msrv (1cc1e39) with main (3cf6fa1)

Open in CodSpeed

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Feb 20, 2026

@sylvestre Are performance benchmarks stable yet?

I noticed div_ceil does produce slightly different codegen: x86_64, aarch64,

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Feb 20, 2026

Benches are broken for msrv 1.70 as rand_core v0.10.0 has msrv 1.85

This might be an acceptable compromise

@sylvestre sylvestre merged commit 2c5f1f9 into uutils:main Feb 20, 2026
26 of 27 checks passed
@xtqqczze xtqqczze deleted the msrv branch February 20, 2026 20:16
@xtqqczze
Copy link
Copy Markdown
Contributor Author

@sylvestre I tried to fix benches for 1.70, but couldn't fix issues with ChaCha8Rng lacking DerefMut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define MSRV policy

2 participants