Skip to content

Commit 953e354

Browse files
committed
clippy: fix warnings with Rust 1.95.0
from the collapsible_match and unnecessary_sort_by lints
1 parent 0ef1670 commit 953e354

3 files changed

Lines changed: 5 additions & 7 deletions

File tree

src/uu/pgrep/src/process_matcher.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -405,9 +405,9 @@ fn process_flag_o_n(
405405
.collect::<Vec<_>>();
406406

407407
if settings.newest {
408-
filtered.sort_by(|a, b| b.pid.cmp(&a.pid));
408+
filtered.sort_by_key(|b| std::cmp::Reverse(b.pid));
409409
} else {
410-
filtered.sort_by(|a, b| a.pid.cmp(&b.pid));
410+
filtered.sort_by_key(|a| a.pid);
411411
}
412412

413413
vec![filtered.first().cloned().unwrap().clone()]

src/uu/pmap/src/smaps_format_parser.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -316,10 +316,8 @@ pub fn parse_smaps(contents: &str) -> Result<SmapTable, Error> {
316316
let val = val.strip_suffix(" kB").unwrap_or(val);
317317
let val = get_smap_item_value(val)?;
318318
match key {
319-
pmap_field_name::SIZE => {
320-
if smap_entry.map_line.size_in_kb != val {
321-
return Err(Error::from(ErrorKind::InvalidData));
322-
}
319+
pmap_field_name::SIZE if smap_entry.map_line.size_in_kb != val => {
320+
return Err(Error::from(ErrorKind::InvalidData));
323321
}
324322
pmap_field_name::KERNEL_PAGE_SIZE => {
325323
smap_entry.kernel_page_size_in_kb = val;

src/uu/ps/src/sorting.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ pub(crate) fn sort(input: &mut [ProcessInformation], _matches: &ArgMatches) {
1313

1414
/// Sort by pid. (Default)
1515
fn sort_by_pid(input: &mut [ProcessInformation]) {
16-
input.sort_by(|a, b| a.pid.cmp(&b.pid));
16+
input.sort_by_key(|a| a.pid);
1717
}

0 commit comments

Comments
 (0)