slabtop: implemented tui#371
Conversation
|
Yep, there is definitely some performance issue, it constantly uses ~70% of CPU on my machine ;-) |
7b35c84 to
de3e31f
Compare
|
CPU usage is now reduced by slowing down the redraw speed, but redrawing is still triggered once the window size is changed. But I think it's as expected, as it avoids confusing TUI output :) |
de3e31f to
8022388
Compare
|
Hi, this pr has been finished for a long time. I've reorganized the commits and could you have a look about it? :) |
|
It looks like you added some unrelated stuff with your latest commit :| |
|
After much deliberation I'm going to close this pr: procps-ng seems to be in the process of completely rewriting its TUI. |
|
Hm, where do you see that they are rewriting the TUI? As far as I can see the latest commit related to |
|
I noticed that the top command in procps-ng has almost completely rewritten the TUI. @Bluemangoo reminded me that top now has a more modern TUI, so I think we may not need to stick strictly to the original interface. Also, the quality of this PR doesn't look very high right now, so I plan to create a new PR to implemented the TUI of slabtop. |
fix #190
This pr also implemented refresh by
spaceand exit byq, but not implemented-oflag: due to performance considerations, only a portion of the list will be rendered at this time.