Skip to content

slabtop: implemented tui#371

Closed
Krysztal112233 wants to merge 5 commits into
uutils:mainfrom
Krysztal112233:feat/slabtop/tui
Closed

slabtop: implemented tui#371
Krysztal112233 wants to merge 5 commits into
uutils:mainfrom
Krysztal112233:feat/slabtop/tui

Conversation

@Krysztal112233

@Krysztal112233 Krysztal112233 commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator

fix #190

This pr also implemented refresh by space and exit by q, but not implemented -o flag: due to performance considerations, only a portion of the list will be rendered at this time.

@cakebaker

cakebaker commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

Yep, there is definitely some performance issue, it constantly uses ~70% of CPU on my machine ;-)

@Krysztal112233

Copy link
Copy Markdown
Collaborator Author

CPU usage is now reduced by slowing down the redraw speed, but redrawing is still triggered once the window size is changed.

But I think it's as expected, as it avoids confusing TUI output :)

@Krysztal112233

Copy link
Copy Markdown
Collaborator Author

Hi, this pr has been finished for a long time. I've reorganized the commits and could you have a look about it? :)

@cakebaker @sylvestre

@cakebaker

Copy link
Copy Markdown
Contributor

It looks like you added some unrelated stuff with your latest commit :|

@Krysztal112233

Copy link
Copy Markdown
Collaborator Author

After much deliberation I'm going to close this pr: procps-ng seems to be in the process of completely rewriting its TUI.

@cakebaker

Copy link
Copy Markdown
Contributor

Hm, where do you see that they are rewriting the TUI? As far as I can see the latest commit related to slabtop was in April and that was a minor UI change, increasing column sizes.

@Krysztal112233

Krysztal112233 commented Aug 24, 2025

Copy link
Copy Markdown
Collaborator Author

I noticed that the top command in procps-ng has almost completely rewritten the TUI. @Bluemangoo reminded me that top now has a more modern TUI, so I think we may not need to stick strictly to the original interface. Also, the quality of this PR doesn't look very high right now, so I plan to create a new PR to implemented the TUI of slabtop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TUI for command slabtop

2 participants