--posix should reject GNU substitute flags i/I #401#419
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
- Coverage 82.67% 82.52% -0.16%
==========================================
Files 13 13
Lines 5997 6007 +10
Branches 347 350 +3
==========================================
- Hits 4958 4957 -1
- Misses 1036 1047 +11
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| //--posix should reject GNU substitute flags i/I https://github.com/uutils/sed/issues/401 | ||
| #[test] |
There was a problem hiding this comment.
Please also add a test for the m flag (different code path).
|
|
||
| 'i' | 'I' => { | ||
| if context.posix { | ||
| return compilation_error(lines, line, "unknown option to 's'"); |
There was a problem hiding this comment.
Define a constant for the error message and use it throughout. (See current main branch.)
There was a problem hiding this comment.
But that wouldn't comply with the current code style, for example, the error message isn't a constant on line 386
There was a problem hiding this comment.
You're almost right, but things change 😃. As I wrote, check the current main branch.
for more information, see https://pre-commit.ci
|
Can I review for merging? If not, please ping me when ready. |
It's ready for merge IMO. |
2 participants
resolves #401