Skip to content

Commit 5e4b56a

Browse files
committed
reviews: suggest contributing missing tests upstream to GNU
1 parent 773a88d commit 5e4b56a

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

content/reviews.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ check these before requesting a review, your PR will move much faster.
4747
tracked with `remaining-gnu-error.py`) should not go backwards; a
4848
compatibility fix should ideally add the now-passing test. Error messages and
4949
exit codes should match GNU, checked with `LANG=C` (except for locale bugs).
50+
- If the GNU test suite passes but you still found a behavior difference, that is
51+
a gap in their coverage: please contribute the missing test upstream to GNU to
52+
improve their test suite.
5053
- **It updates docs, help and translations.** A new option or behavior should
5154
also update the `--help` text, the documentation, the generated man pages, and
5255
at least the English `locales/en-US.ftl` strings.

0 commit comments

Comments
 (0)