Skip to content

Commit bad0629

Browse files
committed
Minor updates
1 parent 4def40f commit bad0629

3 files changed

Lines changed: 11 additions & 9 deletions

File tree

src/flexibleSubsetSelection/dataset.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ def __len__(self) -> int:
418418

419419
def __getattr__(self, attr: str) -> np.ndarray:
420420
"""
421-
Returns the specified transformed version of the dataset if specified.
421+
Returns the specified transformed version of the dataset.
422422
423423
Args:
424424
attr: Specify the name of a transform function

src/flexibleSubsetSelection/objective.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@
1818

1919

2020
def preserveMetric(
21-
subset: np.ndarray, metric: Callable, datasetMetric: ArrayLike, p: int | str = 1
21+
subset: np.ndarray,
22+
metric: Callable,
23+
datasetMetric: ArrayLike,
24+
p: int | str = 1
2225
) -> float:
2326
"""
2427
An objective function for preserving a metric between a dataset and a subset
@@ -70,11 +73,6 @@ def outlierness(subset: np.ndarray, neighbors: int = 20) -> float:
7073
lof.fit(subset)
7174
return lof.negative_outlier_factor_
7275

73-
74-
def discreteDistribution(array: np.ndarray) -> float:
75-
return 0
76-
77-
7876
def discreteCoverage(array: np.ndarray) -> float:
7977
"""
8078
Computes the discrete coverage of the one hot encoded array

src/flexibleSubsetSelection/transform.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,12 @@ def discretize(
8686
strategy: sklearn KBinsDiscretizer strategy to use.
8787
"""
8888
selected = data[:, indices]
89-
discretizer = KBinsDiscretizer(n_bins=bins, encode="ordinal", strategy=strategy)
90-
return discretizer.fit_transform(selected)
89+
discretizer = KBinsDiscretizer(
90+
n_bins = bins,
91+
encode = "ordinal",
92+
strategy = strategy
93+
)
94+
return discretizer.fit_transform(selected).astype(int)
9195

9296
@staticmethod
9397
def encode(

0 commit comments

Comments
 (0)