Fix failing ArmPL SCAL tests#723
Merged
Merged
Conversation
The BLAS SCAL function returns immediately if INCX<=0. The reference USM calls pass in ABS(INCX) but the ArmPL calls were just passing in INCX. We were therefore comparing functions called with two different inputs, and the tests were failing. The fix is to pass ABS(INCX) into the ArmPL calls as well, in common with other ArmPL calls to BLAS functions in this file (e.g. compare the ArmPL and USM nrm2 calls).
Contributor
Author
|
This fixes the failing SCAL tests, but there are still further unrelated BLAS rank-update failures that I will investigate separately. |
Contributor
|
Indeed I just noticed this when testing 26.01. It was passing these tests with previous versions, so something changed in armpl, no? |
mkrainiuk
approved these changes
Apr 23, 2026
mkrainiuk
left a comment
mkrainiuk
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix! Looks good to me.
andrewtbarker
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The BLAS SCAL function returns immediately if INCX<=0. The reference USM calls pass in ABS(INCX) but the ArmPL calls were just passing in INCX. We were therefore comparing functions called with two different inputs, and the tests were failing. The fix is to pass ABS(INCX) into the ArmPL calls as well, in common with other ArmPL calls to BLAS functions in this file (e.g. compare the ArmPL and USM nrm2 calls).
Checklist
All Submissions
test.log