You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR changes the logic of logistic regression on GPU to use oneDAL for predictions even if the model was fitted through scikit-learn, by creating a oneDAL object on-the-fly from the fitted coefficients.
Checklist:
Completeness and readability
I have commented my code, particularly in hard-to-understand areas.
Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
I have resolved any merge conflicts that might occur with the base branch.
Testing
I have run it locally and tested the changes extensively.
All CI jobs are green or I have provided justification why they aren't.
I have extended testing suite if new functionality was introduced in this PR.
From the description it is not clear which problem does this PR solve? I.e. what's wrong with the current approach?
Is it also related to 'everything follows X' issue?
From the description it is not clear which problem does this PR solve? I.e. what's wrong with the current approach? Is it also related to 'everything follows X' issue?
Scikit-learn also supports array API, so there can be cases where .fit() falls back to scikit-learn, but then .predict() still meets the conditions to offload to oneDAL, other than there not being a oneDAL object.
Apart from that, this should also make it easier later on to implement move_estimator_to.
Looks like there is still a private CI test fail (AttributeError: 'numpy.ndarray' object has no attribute 'device') for py3.10 GPU tests - at least the error message there coincides with the changes here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the logic of logistic regression on GPU to use oneDAL for predictions even if the model was fitted through scikit-learn, by creating a oneDAL object on-the-fly from the fitted coefficients.
Checklist:
Completeness and readability
Testing