Skip to content

MAINT: Implement namespace checks for KMeans#3149

Merged
david-cortes-intel merged 2 commits into
uxlfoundation:mainfrom
david-cortes-intel:km_xp
May 14, 2026
Merged

MAINT: Implement namespace checks for KMeans#3149
david-cortes-intel merged 2 commits into
uxlfoundation:mainfrom
david-cortes-intel:km_xp

Conversation

@david-cortes-intel
Copy link
Copy Markdown
Contributor

Description

Implements device and namespace compatibility checks for KMeans.


Checklist:

Completeness and readability

  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@david-cortes-intel
Copy link
Copy Markdown
Contributor Author

/azp run Nightly

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sklearnex/cluster/k_means.py 0.00% 4 Missing and 4 partials ⚠️
Flag Coverage Δ
azure 77.32% <0.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sklearnex/cluster/k_means.py 81.37% <0.00%> (-3.40%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ethanglaser
Copy link
Copy Markdown
Contributor

Just make sure to run private CI on these before merging since that's where we can actually verify GPU stuff

@ethanglaser
Copy link
Copy Markdown
Contributor

/intelci: run

@david-cortes-intel
Copy link
Copy Markdown
Contributor Author

/intelci: run

@david-cortes-intel david-cortes-intel merged commit 4fb1b63 into uxlfoundation:main May 14, 2026
22 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants