Update minima version#1832
Conversation
NamelessOne91
force-pushed
the
update_minima_version
branch
7 times, most recently
from
3eed87d to
21ebaec
Compare
NamelessOne91
force-pushed
the
update_minima_version
branch
from
91831af to
ee0b5bf
Compare
NamelessOne91
force-pushed
the
update_minima_version
branch
from
337900f to
eddb28c
Compare
NamelessOne91
force-pushed
the
update_minima_version
branch
from
eddb28c to
1a6ca23
Compare
There was a problem hiding this comment.
Hi @NamelessOne91, I would like that we discuss about this PR.
The title only describe an update of minima version in sumaform, but in fact, now we are injecting a minima mirror as part of our regular server modules. In particular, I dislike and discourage the idea of downloading minima mirror binary inside the container and run it inside the container, instead, I think that the way containers prefers to work is with volumes, and I think we need to handle minima mirror from the server host, and include an additional volume on the container pointing to the content.
EDITED:
Wow.. In fact that has been there forever... Ok.
I will approve the PR, because it just do cosmetical changes, but I will open a new card to address my concern.
| {% set host = grains.get('mirror') | default('download.opensuse.org', true) %} | ||
| storage: | ||
| type: file | ||
| path: /srv/www/htdocs/pub/ | ||
|
|
||
| http: | ||
| - url: http://{{ host }}/repositories/systemsmanagement:/Uyuni:/Test-Packages:/Updates/rpm | ||
| - url: http://{{ host }}/repositories/systemsmanagement:/Uyuni:/Test-Packages:/Appstream/rhlike |
There was a problem hiding this comment.
IMHO, this YAML file should be part of mirror folder, as it aims to be used by a minima mirror. Also, this would benefit of not having the file duplicated in server and server_containerized.
srbarrios
dismissed
their stale review
Dismissing the request for changes as I noticed the code it was in place since the beginning. I will open a card to refactor it instead.
NamelessOne91
force-pushed
the
update_minima_version
branch
5 times, most recently
from
6d252b0 to
081f221
Compare
NamelessOne91
force-pushed
the
update_minima_version
branch
from
081f221 to
99c8207
Compare
5 participants
What does this PR change?
Updates Salt states so that they all use the latests (at the time of writing) available minima version.