feat: enhance Kubernetes support config to collect cluster data#736
feat: enhance Kubernetes support config to collect cluster data#736katara-Jayprakash wants to merge 8 commits into
Conversation
Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>
Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>
Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>
Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>
katara-Jayprakash
changed the title
| ) | ||
|
|
||
| // RunSupportConfigOnKubernetesHost will run supportconfig command on kubernetes machine. | ||
| func RunSupportConfigOnKubernetesHost(dir string, namespace string, filter string) ([]string, error) { |
There was a problem hiding this comment.
this isn't my code but responsible for blocking my pr! should i refactored/fix it sir @cbosdo ?
There was a problem hiding this comment.
ok i refactor it and to achieve the complexity reduction, i try to introduce the golang inline if-else method but this leads me to removed the else blocks containing warning logs and seems like it work!
Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>
Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>
Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>
|
cbosdo
left a comment
cbosdo
left a comment
There was a problem hiding this comment.
I am not sure how this should look like ATM with the Kubernetes move out of uyuni-tools. We probably want to get inspiration from https://github.com/rancherlabs/support-tools/blob/master/collection/rancher/v2.x/logs-collector/rancher2_logs_collector.sh. In any case, mgradm is not a good idea for Kubernetes as it is meant to run on a cluster node… and this won't be possible.
|
2 participants
What does this PR change?
the main objective of this pr is to extends the
mgradm support configto collect Kubernetes cluster information when the server runs on Kubernetes.add description
Codespace
Check if you already have a running container clicking on
Test coverage
No tests: add explanation
No tests: already covered
Unit tests were added
DONE
Links
Issue(s): #126
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!