fix: add timeout to HTTP client in GetURLBody#768
Open
mihir-dixit2k27 wants to merge 1 commit into
Open
Conversation
The existing GetURLBody function used the package-level http.Get which has no timeout configured. If a remote server hangs or is slow to respond, the download would block indefinitely with no way to recover short of killing the process. Switched to a local http.Client with a one-minute timeout, which is the same value already used by the API client in shared/api/api.go. Signed-off-by: Mihir Dixit <dixitmihir1@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http.GetinGetURLBodyuseshttp.DefaultClientwhich has notimeout. If the server is unresponsive, the process hangs indefinitely.
Fixed by using a local
http.Client{Timeout: time.Minute}instead,same as what
shared/api/api.goalready does.