refactor: extract @VaadinSessionScoped activation into managed bean#515
Open
mcollovati wants to merge 2 commits into
Open
refactor: extract @VaadinSessionScoped activation into managed bean#515mcollovati wants to merge 2 commits into
@VaadinSessionScoped activation into managed bean#515mcollovati wants to merge 2 commits into
Conversation
github-project-automation
Bot
moved this to 🔎Iteration reviews
in Vaadin Flow | Hilla | Kits ongoing work
Contributor
|
Let's also follow the internal discussion in Slack. |
Move the activation predicate and storage-access logic out of `VaadinSessionScopedContext` into a nested `ContextualStorageManager` managed bean. The context becomes a thin delegator. As a side effect, applications may replace the bean via CDI `@Specializes` to adjust behavior — though the manager is intentionally undocumented and overriding it is at the integrator's own risk. Adds integration tests covering the strict default and the lenient `@Specializes` scenario from a background thread that does not hold the session lock. References #506
mcollovati
force-pushed
the
feat/pluggable-vaadinsessionscope-context-activation
branch
from
b55d903 to
f3b3b0f
Compare
heruan
reviewed
Jun 2, 2026
| }, "background-event-fire"); | ||
| thread.start(); | ||
| try { | ||
| thread.join(5000); |
Member
There was a problem hiding this comment.
Wouldn't this hold the lock for the whole 5 secs?
Contributor
Author
There was a problem hiding this comment.
This is a dirty hack to avoid deadlocks in the test. Let me rewrite it in a better way
Contributor
Author
There was a problem hiding this comment.
Refactored view and test
heruan
requested changes
Jun 2, 2026
`SessionContextSpecializesView` joined the spawned background thread with a 5 s timeout: in the lenient `@Specializes` deployment the thread waits in `VaadinSession#accessSynchronously` for the session lock held by the joining request thread, so an unbounded join would deadlock. Every click stalled the full 5 s and the assertions raced the still-running thread. The click listener now only starts the thread, removing the lock inversion entirely. The thread increments a completion counter in its `finally` block, and the tests synchronize on it via a new `waitForCount()` helper before asserting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the activation predicate and storage-access logic out of
VaadinSessionScopedContextinto a nestedContextualStorageManagermanaged bean. The context becomes a thin delegator. As a side effect, applications may replace the bean via CDI@Specializesto adjust behavior — though the manager is intentionally undocumented and overriding it is at the integrator's own risk.Adds integration tests covering the strict default and the lenient
@Specializesscenario from a background thread that does not hold the session lock.References #506