Conversation
Fixes #9240 Note1: Spreadsheet tabs initial alignment is wrong if the first tab is not the selected one when Spreadsheet is placed on Dialog. This is not regression from this PR, but a different bug that needs to be addressed separately. Note2: When Spreadsheet is in Dialog, inserting comment does not work. This is not regression from this PR, as inserting comment after this PR still works, when Spreadsheet is not in Dialog. This is different bug that needs to be address separately. - Actually these bugs happen also with Vaadin 24.10, so they are not regressions from Dialog's native popover refactor.
|
|
There's one issue I found and it relates with the modal dialogs. Perhaps, with the usage of native popover, there's no need to have the Modal Dialog (doesn't work)ss-dialog-popover.mp4Modaless Dialog (works)ss-modeless-dialog-popover.mp4There are also a lot of errors logged in the client console when the It seems to be unrelated to these changes, though, as I verified it in |
@DiegoCardoso Exactly. Thus I would prefer to do separate PR about that, which could be more clearly backported to Vaadin 24 as well. The native popover implementation is Vaadin 25 specific. |
|
I've created PR #9303 based on this (still in draft). The main change is to render the overlays as children of the Spreadsheet instances instead of appending them to , which fixes the issue with modal dialogs. This also resolves the issue mentioned above regarding adding comments to cells when a Spreadsheet is inside a dialog. |
2 participants
Fixes #9240
Note1: Spreadsheet tabs initial alignment is wrong if the first tab is not the selected one when Spreadsheet is placed on Dialog. This is not regression from this PR, but a different bug that needs to be addressed separately.
Note2: When Spreadsheet is in Dialog, inserting comment does not work. This is not regression from this PR, as inserting comment after this PR still works, when Spreadsheet is not in Dialog. This is different bug that needs to be address separately.