fix: update method call in ComboBox to __focusIndex#9385
Draft
DiegoCardoso wants to merge 2 commits into
Draft
Conversation
After vaadin/web-components#11862, the feature moved from the public method `scrollToIndex` to the private `__focusIndex`. Also renamed the private method name to align with the web-component's method.
vursen
reviewed
May 28, 2026
DiegoCardoso
force-pushed
the
fix/combo-box/update-method-name
branch
from
bd266a1 to
fbce043
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After vaadin/web-components#11862, the feature moved from the public method
scrollToIndexto the private__focusIndex. Also renamed the private method name to align with the web-component's method.Note
Keeping it as draft until the next web-components version is released
Type of change