feat: add field highlighting for ai updated fields#9413
Conversation
| * handler | ||
| * @return this controller, for chaining | ||
| */ | ||
| public FormAIController withFieldValuesChanged( |
There was a problem hiding this comment.
The method naming doesn't fit into the controller interface. We've typically used the with-prefixed API in builders
There was a problem hiding this comment.
Should be changed to addFieldValueChangedListener with field, old value, new value.
There was a problem hiding this comment.
Updated the PR:
- Listener name is now
addFieldValueChangedListener FieldValueChangenow contains theHasValuefield- The listener parameter consumer now provides the list of changes rather than a map.
| static void show(Element field, String userId) { | ||
| field.executeJs( | ||
| "customElements.get('vaadin-field-highlighter')" | ||
| + ".addUser(this, {id: $0, name: 'AI', colorIndex: 0})", |
There was a problem hiding this comment.
The AI-tag looks somewhat unexpected
There was a problem hiding this comment.
The decision after discussion: keep the name as "AI" for now.
| * entry — other users on the field stay untouched. | ||
| */ | ||
| static void show(Element field, String userId) { | ||
| field.executeJs( |
There was a problem hiding this comment.
This will probably not survive reattach. Should be wrapped in an attach listener
|
2 participants
Description
This PR:
withFieldValuesChanged(Consumer<Map<HasValue, FieldValueChange>>), which fires once per successful turn. Ignored fields are excluded. Skipped when the turn ended in error or when no field changed.showHighlight(HasValue)andhideHighlight(HasValue)to control the highlighter. Each controller carries a per-instance UUID id (vaadin-ai-<uuid>) and usesaddUser/removeUser, so the AI highlight coexists with any other field-highlighter user the application keeps on the same field. The highlight is not retained across detach/re-attach.Fixes https://github.com/orgs/vaadin/projects/103/views/1?filterQuery=&pane=issue&itemId=193540699
Type of change
Checklist