feat: DownloadAction for the action trigger framework#24432
Open
Artur- wants to merge 1 commit into
Open
Conversation
Artur-
force-pushed
the
download-action
branch
2 times, most recently
from
ca4bad3 to
ec5d871
Compare
anandfresh
approved these changes
May 27, 2026
Starts a file download in the browser when a trigger fires, using a synthesised <a href download> click inside the gesture. Three flavours: a static URL (optionally with a filename), a DownloadHandler whose stream resource is wired through Element.setAttribute (same lifecycle as Image.setSrc / Anchor.setHref), and an Action.Input<String> for URLs resolved on the client at fire time. No outcome callback — browsers do not report download completion.
|
tltv
reviewed
Jun 2, 2026
| /** | ||
| * Body served by the {@code #download-handler} button's | ||
| * {@link DownloadHandler}. The IT fetches the recorded URL and asserts this | ||
| * exact string, verifying that {@link Element#setAttribute}-driven |
Member
There was a problem hiding this comment.
Qualifier or import missing for the Element API link.
| // browser's native download handling instead of being intercepted as an | ||
| // in-app navigation. Matches Anchor.setHref(DownloadHandler). | ||
| a.setAttribute('router-ignore', ''); | ||
| a.rel = 'noopener'; |
Member
There was a problem hiding this comment.
rel="noopener" is noop without target="_blank" and can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starts a file download in the browser when a trigger fires, using a
synthesised click inside the gesture. Three flavours:
a static URL (optionally with a filename), a DownloadHandler whose
stream resource is wired through Element.setAttribute (same lifecycle
as Image.setSrc / Anchor.setHref), and an Action.Input for URLs
resolved on the client at fire time. No outcome callback — browsers do
not report download completion.