Skip to content

feat: add session lock request, acquire, release events#24498

Merged
heruan merged 4 commits into
mainfrom
feat/session-lock-listener
Jun 3, 2026
Merged

feat: add session lock request, acquire, release events#24498
heruan merged 4 commits into
mainfrom
feat/session-lock-listener

Conversation

@caalador
Copy link
Copy Markdown
Contributor

@caalador caalador commented Jun 2, 2026

Enable listening to session lock request/acquire/release

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Test Results

 1 433 files  +1   1 433 suites  +1   1h 22m 2s ⏱️ - 2m 26s
10 065 tests +6   9 997 ✅ +6  68 💤 ±0  0 ❌ ±0 
10 537 runs  +6  10 468 ✅ +6  69 💤 ±0  0 ❌ ±0 

Results for commit 3620f67. ± Comparison against base commit a35f9be.

♻️ This comment has been updated with latest results.

return;
}
SessionLockEvent event = new SessionLockEvent(this);
for (SessionLockListener listener : sessionLockListeners) {
Copy link
Copy Markdown
Member

@Legioth Legioth Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest firing unlock events in the reverse order so that listeners are "nested"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@heruan heruan changed the title feat: add session lock request, aquire, release events feat: add session lock request, acquire, release events Jun 3, 2026
Comment thread flow-server/src/main/java/com/vaadin/flow/server/VaadinService.java Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 3, 2026

@heruan heruan added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit 0e5c8ed Jun 3, 2026
34 checks passed
@heruan heruan deleted the feat/session-lock-listener branch June 3, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants