feat: multi-module setup and core Micrometer instrumentation#325
Open
heruan wants to merge 13 commits into
Open
feat: multi-module setup and core Micrometer instrumentation#325heruan wants to merge 13 commits into
heruan wants to merge 13 commits into
Conversation
flow-server's session event classes reference jakarta.servlet types, so the servlet API (provided) must be on the classpath for tests that mock them. Mockito 5.20.0 ships a Byte Buddy that supports the JDK the build runs on.
heruan
changed the title
Replaces the unenforced revelc formatter with spotless-maven-plugin (3.5.1) using Flow's eclipse config, import order, wildcard-import ban, and the Vaadin commercial license header. Reformats sources accordingly and adds a spotless:check step to the validation workflow.
caalador
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #324.
Establishes the Maven multi-module project and the framework-agnostic core module providing Micrometer-based instrumentation for Vaadin Flow in standalone (non-Spring) deployments.
What's included
observability-kit-micrometermodule (com.vaadin.observability.micrometer).ObservabilityKit.install(meterRegistry, settings)programmatic bootstrap for standalone use.ObservabilitySettingswith feature toggles (sessions, UIs, navigation, requests, errors, client, traces) and limits.vaadin.sessions.active).Notes
jakarta.servlet-api(provided) and Mockito 5.20.0 are required for the mock-based tests to run.mvn verifygreen (9 unit tests).Out of scope
Spring / Spring Boot integration and the remaining metrics, tracing, and client instrumentation (later parts).