refactor: breadcrumbs base styles and themes#11868
Draft
jouni wants to merge 7 commits into
Draft
Conversation
9ed8205 to
dee184f
Compare
dee184f to
fc3e162
Compare
web-padawan
reviewed
Jun 2, 2026
|
|
||
| :host([slot='overlay']) [part='link']:focus-visible { | ||
| border-radius: var(--vaadin-radius-m); | ||
| /* TODO shouldn't focus the first item when opened with the mouse or at least shouldn't apply the focus-ring attribute */ |
16081ac to
95519ad
Compare
95519ad to
d447d72
Compare
Spec's CSS custom property tables align with the JSDoc on both elements: nine container-level tokens (typography, color, gap, two mask-image icons + size) and two item-level tokens (border radius, item gap). The separator hook is `--vaadin-breadcrumbs-separator-icon` across spec references; KDD #5, the overflow-separator bullet, and the item separator-rendering bullet are updated accordingly. Added Discussion entry explaining the token shape.
web-padawan
reviewed
Jun 2, 2026
Member
web-padawan
left a comment
There was a problem hiding this comment.
Pushed an update to the spec to list new custom CSS properties, also fixed JSDoc.
I'll continue reviewing the actual implementation later and update specs if needed.
|
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This is how I would want the component styles to be. Not sure what we need to change in the specs to get closer to this.
Changes on a high level
…character.--vaadin-breadcrumbs-*custom properties for easier customization.accentandprimary, respectively) for coloring the links, which makes it possible to distinguish between link and non-link items without interacting with them.slashvariant to base styles, which changes the default separator icon from a chevron to a slash.