refactor: render breadcrumbs overflow button icon using mask-image#11881
Open
web-padawan wants to merge 1 commit into
Open
refactor: render breadcrumbs overflow button icon using mask-image#11881web-padawan wants to merge 1 commit into
web-padawan wants to merge 1 commit into
Conversation
web-padawan
force-pushed
the
breadcrumbs-overflow-icon
branch
from
80b9813 to
ec38e6e
Compare
web-padawan
changed the title
web-padawan
force-pushed
the
breadcrumbs-overflow-icon
branch
4 times, most recently
from
71f34d1 to
58be05d
Compare
The `…` character depends on the font and locale, so it doesn't line up visually with the chevron separator. Switching to a mask-image SVG keeps the overflow button icon consistent with the rest of the component's iconography and adds a `--vaadin-breadcrumbs-overflow-icon` override hook that mirrors `--vaadin-breadcrumbs-separator`. A new shared `--_vaadin-icon-ellipsis` token lands in `style-props.js` for reuse.
web-padawan
force-pushed
the
breadcrumbs-overflow-icon
branch
from
58be05d to
9874ae3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #11868
--_vaadin-icon-ellipsisSVG topackages/component-base/src/styles/style-props.js…character--vaadin-breadcrumbs-overflow-iconcustom CSS property to allow customizing the iconPart of #7960