refactor: update breadcrumbs item padding, do not clip overflow#11883
Draft
web-padawan wants to merge 1 commit into
Draft
refactor: update breadcrumbs item padding, do not clip overflow#11883web-padawan wants to merge 1 commit into
web-padawan wants to merge 1 commit into
Conversation
web-padawan
force-pushed
the
breadcrumbs-layout
branch
from
e988589 to
a7ab9b3
Compare
web-padawan
changed the title
web-padawan
force-pushed
the
breadcrumbs-layout
branch
from
a7ab9b3 to
761f80c
Compare
web-padawan
force-pushed
the
breadcrumbs-layout
branch
2 times, most recently
from
fc6d10a to
79b857b
Compare
web-padawan
changed the title
…pping Trail items now carry inline padding for a larger click target and an offset focus outline, with a matching negative margin-inline that keeps the visual width unchanged. The list flex container drops overflow: hidden so focus outlines render unclipped. The overflow button gets a padding/margin formula to meet WCAG 2.5.8 minimum click target size.
web-padawan
force-pushed
the
breadcrumbs-layout
branch
from
79b857b to
3052dd8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #11868
Depends on #11881
[part='link']/[part='nolink']for a larger click target and an offset focus outlinemargin-inlineon trail items so the visual width is unchanged (overlay items keep the padding so hover/focus backgrounds can fill the row)overflow: hiddenand the focus-outline padding workaround from[part='list']. Items still collapse to the overflow menu by setting width, min-width and max-width on the host and the internal list.padding: 0with a padding/negative-margin formula that meets WCAG 2.5.8 (24×24 px) without changing visual sizePart of #7960