fix: don't pad dashes adjacent to inline markup (#1029)

Signed-off-by: Joseph Kato <joseph@jdkato.io>

Author: jdkato

internal/lint/ast.go

@@ -109,10 +109,11 @@ func (l *Linter) lintHTMLTokens(f *core.File, raw []byte, offset int) error { //
 				txt, skip = clean(txt, attr, skip || skipClass, inline)
 				// `clean` prefixes inline content with a space so it doesn't
 				// fuse with the preceding text. When that content directly
-				// follows an opening bracket (e.g., a link inside parentheses,
-				// `([HNSW](...))`), the space is spurious and breaks patterns
-				// like `(ACRONYM)`. See #1056.
-				if strings.HasPrefix(txt, " ") && endsWithOpenBracket(buf) {
+				// follows a tight boundary -- an opening bracket (a link in
+				// parentheses, `([HNSW](...))`, #1056) or a dash
+				// (`Triggers—**Article**`, #1029) -- the space is spurious and
+				// produces false positives like ` —` / `( ACRONYM)`.
+				if strings.HasPrefix(txt, " ") && endsWithTightBoundary(buf) {
 					txt = txt[1:]
 				}
 				buf.WriteString(txt)
@@ -230,16 +231,15 @@ func shouldBeSkipped(tagHistory []string, ext string) bool {
 	return false
 }
 
-// endsWithOpenBracket reports whether the buffer's last byte is an opening
-// bracket, meaning inline content that follows it shouldn't be padded with a
-// leading space. See #1056.
-func endsWithOpenBracket(buf *bytes.Buffer) bool {
-	b := buf.Bytes()
-	if len(b) == 0 {
-		return false
-	}
-	switch b[len(b)-1] {
-	case '(', '[', '{':
+// endsWithTightBoundary reports whether the buffer ends with a character that
+// binds tightly to what follows -- an opening bracket or a dash -- so inline
+// content placed after it shouldn't be padded with a leading space. Handles
+// "([HNSW](...))" (#1056) and "Triggers—**Article**" (#1029). We decode the
+// last rune because dashes are multi-byte.
+func endsWithTightBoundary(buf *bytes.Buffer) bool {
+	r, _ := utf8.DecodeLastRune(buf.Bytes())
+	switch r {
+	case '(', '[', '{', '—', '–':
 		return true
 	default:
 		return false
@@ -249,8 +249,10 @@ func endsWithOpenBracket(buf *bytes.Buffer) bool {
 func clean(txt, attr string, skip, inline bool) (string, bool) {
 	// Closing brackets are included so that inline content immediately
 	// followed by one (e.g., a link inside parentheses) doesn't get a spurious
-	// space inserted before it -- "(HNSW)" rather than "(HNSW )". See #1056.
-	punct := []string{".", "?", "!", ",", ":", ";", ")", "]", "}"}
+	// space inserted before it -- "(HNSW)" rather than "(HNSW )" (#1056). Dashes
+	// are included so text like "—This" right after a link isn't padded to
+	// " —This" (#1029).
+	punct := []string{".", "?", "!", ",", ":", ";", ")", "]", "}", "—", "–"}
 	first, _ := utf8.DecodeRuneInString(txt)
 	starter := core.StringInSlice(string(first), punct) && !skip
 

testdata/features/misc.feature

@@ -112,6 +112,15 @@ Feature: Misc
             test.md:50:11:Markup.SentSpacing:"d.A" must contain one and only one space.
             """
 
+    Scenario: Dashes adjacent to inline markup (#1029)
+        # A dash touching a link/bold (`[x](y)—z`, `**x**—z`, `x—**y**`) must not
+        # gain a spurious surrounding space; a genuinely spaced dash still does.
+        When I test "misc/dashes"
+        Then the output should contain exactly:
+            """
+            test.md:1:24:Test.Dashes:Remove the spaces around the dash.
+            """
+
     Scenario: Spelling
         When I test "spelling"
         Then the output should contain exactly:

testdata/fixtures/misc/dashes/.vale.ini

@@ -0,0 +1,5 @@
+StylesPath = styles
+MinAlertLevel = suggestion
+
+[*.md]
+BasedOnStyles = Test

testdata/fixtures/misc/dashes/styles/Test/Dashes.yml

@@ -0,0 +1,7 @@
+extends: existence
+message: "Remove the spaces around the dash."
+level: error
+scope: text
+nonword: true
+tokens:
+  - '\s—|—\s'

testdata/fixtures/misc/dashes/test.md

@@ -0,0 +1,7 @@
+A genuinely spaced word — dash should be flagged on this line.
+
+A [linked term](./url)—joined to following text on this line.
+
+Bold **term**—joined to following text here on this line.
+
+The Triggers—**Article Published** connector on this line.