chore: drop cucumber on WIndows

Signed-off-by: Joseph Kato <joseph@jdkato.io>

Author: jdkato

.github/workflows/test.yml

@@ -75,7 +75,6 @@ jobs:
         shell: bash # use the runner's Git bash for all steps
     env:
       CGO_ENABLED: "1" # required for the tree-sitter parsers
-      BUNDLE_GEMFILE: ${{ github.workspace }}/testdata/Gemfile
     steps:
       - uses: actions/checkout@v5
         with:
@@ -85,44 +84,14 @@ jobs:
         with:
           go-version: "1.25.7"
 
-      - uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: "3.3"
-
-      - uses: actions/setup-node@v4
-        with:
-          node-version: "20"
-
-      - uses: actions/setup-python@v5
-        with:
-          python-version: "3.x"
-
-      - uses: actions/setup-java@v4
-        with:
-          distribution: temurin
-          java-version: "17"
-
-      - name: Install documentation toolchain
-        run: |
-          choco install --no-progress -y xsltproc
-          # Git ships a non-functional xsltproc; drop it so the choco one wins.
-          rm -f "/c/Program Files/Git/usr/bin/xsltproc.exe" || true
-          python -m pip install --upgrade docutils sphinx  # rst2html
-          gem install asciidoctor
-          npm install -g mdx2vast
-          curl -fsSL -o dita-ot-3.6.zip \
-            https://github.com/dita-ot/dita-ot/releases/download/3.6/dita-ot-3.6.zip
-          unzip -q dita-ot-3.6.zip
-          echo "$PWD/dita-ot-3.6/bin" >> "$GITHUB_PATH"
-
-      - name: Setup (bundle install)
-        run: cd testdata && bundle install
-
       - name: Build
         run: go build -o bin/vale.exe ./cmd/vale
 
-      - name: Test
-        run: |
-          export PATH="$PWD/bin:$PATH"
-          go test ./internal/core ./internal/lint ./internal/check ./internal/nlp ./internal/glob ./cmd/vale
-          cd testdata && cucumber --format progress
+      # NOTE: The Cucumber suite runs on Linux only. Its aruba -> childprocess ->
+      # ffi stack can't spawn processes on modern Windows + Ruby 3.x (every step
+      # fails with `ChildProcess::Error: Unknown error`); AppVeyor only managed
+      # it on the now-unavailable Ruby 2.4. Windows still covers the build
+      # (including CGO/tree-sitter) and the Go unit tests -- which is where the
+      # Windows-specific behavior (path handling, etc.) actually lives.
+      - name: Test (Go)
+        run: go test ./internal/core ./internal/lint ./internal/check ./internal/nlp ./internal/glob ./cmd/vale

internal/system/path_test.go

@@ -2,10 +2,19 @@ package system
 
 import (
 	"path/filepath"
+	"runtime"
 	"testing"
 )
 
 func TestDeterminePath(t *testing.T) {
+	// These cases use Windows-style paths (drive letters, backslash
+	// separators), and DeterminePath joins with the OS-native separator. They
+	// only resolve correctly on Windows -- elsewhere `\` isn't a separator, so
+	// skip rather than fail.
+	if runtime.GOOS != "windows" {
+		t.Skip("Windows-only path semantics")
+	}
+
 	tests := []struct {
 		configPath string
 		keyPath    string

testdata/Gemfile

@@ -2,6 +2,5 @@ source 'https://rubygems.org'
 
 gem 'specific_install', '~> 0.3.8'
 gem 'cucumber', '~> 6.1.0'
-gem 'os', '~> 0.9.6'
 
 gem "aruba", "~> 1.1.0"

testdata/Gemfile.lock

@@ -74,7 +74,6 @@ GEM
     mime-types-data (3.2024.1203)
     minitest (5.25.4)
     multi_test (0.1.2)
-    os (0.9.6)
     protobuf-cucumber (3.10.8)
       activesupport (>= 3.2)
       middleware
@@ -100,7 +99,6 @@ PLATFORMS
 DEPENDENCIES
   aruba (~> 1.1.0)
   cucumber (~> 6.1.0)
-  os (~> 0.9.6)
   specific_install (~> 0.3.8)
 
 BUNDLED WITH

testdata/features/steps.rb

@@ -1,15 +1,6 @@
-require 'os'
-
 exe = 'vale'
-if OS.windows?
-  exe += '.exe'
-end
 cmd = (exe + ' --output=line --sort --normalize --relative --no-global')
 
-Given(/^on Unix$/) do
-  pending unless OS.posix?
-end
-
 When(/^I run command "(.*)"$/) do |c|
   step %(I cd to "../../fixtures/formats")
   step %(I run `#{cmd} #{c}`)
@@ -166,19 +157,10 @@
 
 When(/^I run cat "([^\s]+)" "([^\s]+)"$/) do |file, ext|
   step %(I cd to "../../fixtures/formats")
-  if OS.windows?
-    step %(I run `PowerShell -Command Get-Content #{file} | #{cmd} --ext='#{ext}'`)
-  else
-    step %(I run `bash -c 'cat #{file} | #{cmd} --ext="#{ext}"'`)
-  end
+  step %(I run `bash -c 'cat #{file} | #{cmd} --ext="#{ext}"'`)
 end
 
 When(/^I lint string "(.*)"$/) do |string|
   step %(I cd to "../../fixtures/formats")
-  if OS.windows?
-    # FIXME: How do we pass a string with spaces on AppVeyor?
-    step %(I run `#{cmd} "#{string}"`)
-  else
-    step %(I run `#{cmd} '#{string}'`)
-  end
+  step %(I run `#{cmd} '#{string}'`)
 end