Pp add warning and tests#2
Closed
pp-mo wants to merge 2 commits into
Closed
Conversation
Author
|
This was referenced Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, this is what #1 was supposed to be
-- i.e. target you branch so the changes appear back on https://github.com/pp-mo/ncdata/pull/145
Meanwhile, I only made https://github.com/pp-mo/ncdata/pull/147 to check that the changes would work, in advance of your merging them.
So I think if you merge this, and then we close https://github.com/pp-mo/ncdata/pull/147 and go back to https://github.com/pp-mo/ncdata/pull/145,
that is going to be better, because then it's still your branch + your PR.