Skip to content

Pp add warning and tests#2

Closed
pp-mo wants to merge 2 commits into
valeriupredoi:add_warning_and_testsfrom
SciTools:pp__add_warning_and_tests
Closed

Pp add warning and tests#2
pp-mo wants to merge 2 commits into
valeriupredoi:add_warning_and_testsfrom
SciTools:pp__add_warning_and_tests

Conversation

@pp-mo
Copy link
Copy Markdown

@pp-mo pp-mo commented Aug 13, 2025

Sorry, this is what #1 was supposed to be
-- i.e. target you branch so the changes appear back on https://github.com/pp-mo/ncdata/pull/145

Meanwhile, I only made https://github.com/pp-mo/ncdata/pull/147 to check that the changes would work, in advance of your merging them.

So I think if you merge this, and then we close https://github.com/pp-mo/ncdata/pull/147 and go back to https://github.com/pp-mo/ncdata/pull/145,
that is going to be better, because then it's still your branch + your PR.

@pp-mo
Copy link
Copy Markdown
Author

pp-mo commented Aug 13, 2025

Sorry, this is what #1 was supposed to be -- i.e. target your branch (not main), so the changes appear back on pp-mo#145

Meanwhile, I only made pp-mo#147 check it would work, in advance of your adopting it.

So I think if you merge this, and then we close pp-mo#147 and go back to pp-mo#145, that is going to be better, because then it's still your branch + your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant