feat: Add option to override the gitops subscription on remote clusters

Change the default namespace value for gitops sub to the new recommended
default.

Author: darkdoc

README.md

@@ -14,6 +14,7 @@ This chart is used by the Validated Patterns to configure ACM and manage remote
 | acm.mch_spec | object | `{}` | MultiClusterHub spec (empty by default) |
 | acm.spokeGitops.channel | string | `"gitops-1.18"` | Default gitops channel to install on remote clusters |
 | acm.spokeGitops.source | string | `"redhat-operators"` |  |
+| acm.spokeGitops.subscriptionNamespace | string | `"openshift-gitops-operator"` | Default namespace for the gitops subscription on remote clusters |
 | clusterGroup | object | depends on the individual settings | Dictionary of all the clustergroups of the pattern |
 | clusterGroup.managedClusterGroups | object | `{}` | The set of cluters managed by ACM which is running inside this clusterGroup |
 | clusterGroup.subscriptions | object | `{"acm":{"source":"redhat-operators"}}` | Dictionary of subscriptions for this specific clusterGroup |

templates/policies/ocp-gitops-policy.yaml

@@ -33,7 +33,7 @@ spec:
                 kind: Subscription
                 metadata:
                   name: openshift-gitops-operator
-                  namespace: openshift-operators
+                  namespace: {{- if and $.Values.acm.spokeGitops $.Values.acm.spokeGitops.subscriptionNamespace }} {{ $.Values.acm.spokeGitops.subscriptionNamespace }}{{- else }} openshift-gitops-operator{{- end }}
                   labels:
                     operators.coreos.com/openshift-gitops-operator.openshift-operators: ''
                 spec:

tests/ocp_gitops_policy_test.yaml

@@ -56,6 +56,22 @@ tests:
           path: spec.policy-templates[0].objectDefinition.spec.object-templates[0].objectDefinition.spec.source
           value: custom-operators
 
+  - it: Should use subscriptionNamespace for subscription namespace when specified
+    values:
+      - ./clusterselector_values.yaml
+    set:
+      acm:
+        spokeGitops:
+          subscriptionNamespace: test-gitops-namespace
+    asserts:
+      - documentSelector:
+          path: metadata.name
+          value: group-one-gitops-policy
+        equal:
+          path: spec.policy-templates[0].objectDefinition.spec.object-templates[0].objectDefinition.metadata.namespace
+          value: test-gitops-namespace
+
+
   - it: Should use spokeGitops channel and source when both specified
     values:
       - ./clusterselector_values.yaml

values.yaml

@@ -77,7 +77,8 @@ acm:
     source: redhat-operators
     # -- Default gitops channel to install on remote clusters
     channel: "gitops-1.18"
-
+    # -- Default namespace for the gitops subscription on remote clusters
+    subscriptionNamespace: openshift-gitops-operator
 
 # -- Default secretstore configuration variables
 # @default -- depends on the individual settings