Precreate the openshift-gitops-cluster-admin-rolebinding CRB#51
Merged
mbaldessari merged 2 commits intoMar 19, 2026
Merged
Conversation
This is to fix an issue on spokes. See validatedpatterns/clustergroup-chart#103 for the full reasoning. TLDR: we need to drop sync-waves in clustergroup from CRBs to avoid an argo bug, but then without those the SA will never have the right permissions to create another service account, so we precreate the CRB via the acm-chart Closes: validatedpatterns/clustergroup-chart#63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix an issue on spokes. See
validatedpatterns/clustergroup-chart#103
for the full reasoning.
TLDR: we need to drop sync-waves in clustergroup from CRBs to avoid
an argo bug, but then without those the SA will never have the right
permissions to create another service account, so we precreate the
CRB via the acm-chart
Closes: validatedpatterns/clustergroup-chart#63