Skip to content

Allow for extra HealthChecks for argo#71

Merged
mbaldessari merged 1 commit into
validatedpatterns:mainfrom
mbaldessari:custom-hc2
Jun 3, 2026
Merged

Allow for extra HealthChecks for argo#71
mbaldessari merged 1 commit into
validatedpatterns:mainfrom
mbaldessari:custom-hc2

Conversation

@mbaldessari
Copy link
Copy Markdown
Contributor

Tested with:

acm:
  extraResourceHealthChecks:
    - group: app
      kind: Deployment
      check: |
        hs = {}
        if obj.status ~= nil then
          if obj.status.readyReplicas == obj.status.replicas then
            hs.status = "Healthy"
          else
            hs.status = "Progressing"
          end
        end
        return hs

And correctly got the following on the spoke:

oc get argocd -n vp-gitops vp-gitops -o jsonpath='{.spec.resourceHealthChecks}' | jq -r '.[].kind'
Subscription
Deployment

Tested with:
```
acm:
  extraResourceHealthChecks:
    - group: app
      kind: Deployment
      check: |
        hs = {}
        if obj.status ~= nil then
          if obj.status.readyReplicas == obj.status.replicas then
            hs.status = "Healthy"
          else
            hs.status = "Progressing"
          end
        end
        return hs
```

And correctly got the following on the spoke:
```
oc get argocd -n vp-gitops vp-gitops -o jsonpath='{.spec.resourceHealthChecks}' | jq -r '.[].kind'
Subscription
Deployment
```
@darkdoc
Copy link
Copy Markdown
Contributor

darkdoc commented Jun 3, 2026

/lgtm

@mbaldessari mbaldessari merged commit 4d970c3 into validatedpatterns:main Jun 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants