Skip to content

Commit bb40d42

Browse files
darkdocdarkdoc
committed
fix: Drop inferenceservice healthcheck
The HC is no longer needed here, it has been merged in argocd with argoproj/argo-cd#25312
1 parent b63e898 commit bb40d42

2 files changed

Lines changed: 0 additions & 143 deletions

File tree

‎tests/argocd_test.yaml‎

Lines changed: 0 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -36,76 +36,6 @@ tests:
3636
hs.status = "Progressing"
3737
hs.message = "Waiting for PVC"
3838
return hs
39-
- kind: InferenceService
40-
group: serving.kserve.io
41-
check: |
42-
local health_status = {}
43-
44-
health_status.status = "Progressing"
45-
health_status.message = "Waiting for InferenceService to report status..."
46-
47-
if obj.status ~= nil then
48-
49-
local progressing = false
50-
local degraded = false
51-
local status_false = 0
52-
local status_unknown = 0
53-
local msg = ""
54-
55-
if obj.status.modelStatus ~= nil then
56-
if obj.status.modelStatus.transitionStatus ~= "UpToDate" then
57-
if obj.status.modelStatus.transitionStatus == "InProgress" then
58-
progressing = true
59-
else
60-
degraded = true
61-
end
62-
msg = msg .. "0: transitionStatus | " .. obj.status.modelStatus.transitionStatus
63-
end
64-
end
65-
66-
if obj.status.conditions ~= nil then
67-
for i, condition in pairs(obj.status.conditions) do
68-
69-
-- A condition is healthy if its status is True.
70-
-- However, for the 'Stopped' condition, a 'False' status is the healthy state.
71-
local is_healthy_condition = (condition.status == "True")
72-
if condition.type == "Stopped" then
73-
is_healthy_condition = (condition.status == "False")
74-
end
75-
76-
if not is_healthy_condition then
77-
-- This condition represents a problem, so update counters and the message.
78-
if condition.status == "Unknown" then
79-
status_unknown = status_unknown + 1
80-
else
81-
status_false = status_false + 1
82-
end
83-
84-
msg = msg .. " | " .. i .. ": " .. condition.type .. " | " .. condition.status
85-
if condition.reason ~= nil and condition.reason ~= "" then
86-
msg = msg .. " | " .. condition.reason
87-
end
88-
if condition.message ~= nil and condition.message ~= "" then
89-
msg = msg .. " | " .. condition.message
90-
end
91-
end
92-
93-
end
94-
95-
if progressing == false and degraded == false and status_unknown == 0 and status_false == 0 then
96-
health_status.status = "Healthy"
97-
msg = "InferenceService is healthy."
98-
elseif degraded == false and status_unknown >= 0 then
99-
health_status.status = "Progressing"
100-
else
101-
health_status.status = "Degraded"
102-
end
103-
104-
health_status.message = msg
105-
end
106-
end
107-
108-
return health_status
10939
11040
- it: should not render resourceActions when empty
11141
documentIndex: 0

‎values.yaml‎

Lines changed: 0 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -63,79 +63,6 @@ clusterGroup:
6363
hs.message = "Waiting for PVC"
6464
return hs
6565
66-
# Drop once upstream argo cd handles the stopped field correctly
67-
# As of 20251001 there is not a pr/issue in argo yet
68-
- kind: InferenceService
69-
group: serving.kserve.io
70-
check: |
71-
local health_status = {}
72-
73-
health_status.status = "Progressing"
74-
health_status.message = "Waiting for InferenceService to report status..."
75-
76-
if obj.status ~= nil then
77-
78-
local progressing = false
79-
local degraded = false
80-
local status_false = 0
81-
local status_unknown = 0
82-
local msg = ""
83-
84-
if obj.status.modelStatus ~= nil then
85-
if obj.status.modelStatus.transitionStatus ~= "UpToDate" then
86-
if obj.status.modelStatus.transitionStatus == "InProgress" then
87-
progressing = true
88-
else
89-
degraded = true
90-
end
91-
msg = msg .. "0: transitionStatus | " .. obj.status.modelStatus.transitionStatus
92-
end
93-
end
94-
95-
if obj.status.conditions ~= nil then
96-
for i, condition in pairs(obj.status.conditions) do
97-
98-
-- A condition is healthy if its status is True.
99-
-- However, for the 'Stopped' condition, a 'False' status is the healthy state.
100-
local is_healthy_condition = (condition.status == "True")
101-
if condition.type == "Stopped" then
102-
is_healthy_condition = (condition.status == "False")
103-
end
104-
105-
if not is_healthy_condition then
106-
-- This condition represents a problem, so update counters and the message.
107-
if condition.status == "Unknown" then
108-
status_unknown = status_unknown + 1
109-
else
110-
status_false = status_false + 1
111-
end
112-
113-
msg = msg .. " | " .. i .. ": " .. condition.type .. " | " .. condition.status
114-
if condition.reason ~= nil and condition.reason ~= "" then
115-
msg = msg .. " | " .. condition.reason
116-
end
117-
if condition.message ~= nil and condition.message ~= "" then
118-
msg = msg .. " | " .. condition.message
119-
end
120-
end
121-
122-
end
123-
124-
if progressing == false and degraded == false and status_unknown == 0 and status_false == 0 then
125-
health_status.status = "Healthy"
126-
msg = "InferenceService is healthy."
127-
elseif degraded == false and status_unknown >= 0 then
128-
health_status.status = "Progressing"
129-
else
130-
health_status.status = "Degraded"
131-
end
132-
133-
health_status.message = msg
134-
end
135-
end
136-
137-
return health_status
138-
13966
resourceActions: []
14067
resourceExclusions: |
14168
- apiGroups:

0 commit comments

Comments
 (0)