refactor: absorb ZTVP RHBK config into rh-keycloak wrapper#146
Merged
sabre1041 merged 2 commits intoJun 23, 2026
Conversation
minmzzhang
changed the title
Move all ZTVP-specific configuration from the generic rhbk subchart into the rh-keycloak wrapper values: full ZTVP realm definition, realm import placeholders, extra secrets (keycloak-users, ACS OIDC, RHTPA CLI OIDC), SPIFFE Identity Provider enablement, and vault paths. Update rh-keycloak Chart.yaml to depend on rhbk >=0.1.0 (generalized). Also fix pipeline git-clone basic-auth workspace binding to be conditional on git.credentials.enabled, preventing failures when cloning public repos without credentials configured. Signed-off-by: Min Zhang <minzhang@redhat.com>
minmzzhang
force-pushed
the
generalize-rhbk-chart
branch
from
0815516 to
b7aa8da
Compare
Kubernetes normalizes Go duration strings (e.g. "1h" -> "1h0m0s") when storing ExternalSecret CRs, causing ArgoCD to detect a perpetual diff and mark resources as OutOfSync. Use the fully-qualified "1h0m0s" format so the desired manifest matches the live state exactly. Signed-off-by: Min Zhang <minzhang@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rhbksubchart into therh-keycloakwrapper chart values (realm, placeholders, extra secrets, SPIFFE, vault paths)oci://quay.io/validatedpatterns/rhbk >=0.1.0) for the generalized rhbk subchartgit.credentials.enabled)Dependencies
rhbkv0.1.0 OCI artifact published before this PR can be deployed.Test plan
helm lintandhelm templatepass on rh-keycloak wrapper