refactor: remove redundant ImageUpdater typed preservation

mohtork · mohtork · commit 1d48c50f2b1c · 2026-05-16T00:39:20.000+01:00
diff --git a/internal/controller/argo.go b/internal/controller/argo.go
@@ -474,8 +474,6 @@ func createOrUpdateArgoCD(client dynamic.Interface, fullClient kubernetes.Interf
 			return fmt.Errorf("failed to get existing ArgoCD %s/%s: %v", namespace, name, errGet)
 		}
 		argo.SetResourceVersion(oldArgo.GetResourceVersion())
-		argo.Spec.ImageUpdater = oldArgo.Spec.ImageUpdater
-
 		obj, errConvert := runtime.DefaultUnstructuredConverter.ToUnstructured(argo)
 		if errConvert != nil {
 			return fmt.Errorf("failed to convert ArgoCD to unstructured for update: %v", errConvert)

Original file line number	Diff line number	Diff line change
`@@ -474,8 +474,6 @@ func createOrUpdateArgoCD(client dynamic.Interface, fullClient kubernetes.Interf`
`474`	`474`	`return fmt.Errorf("failed to get existing ArgoCD %s/%s: %v", namespace, name, errGet)`
`475`	`475`	`}`
`476`	`476`	`argo.SetResourceVersion(oldArgo.GetResourceVersion())`
`477`		`- argo.Spec.ImageUpdater = oldArgo.Spec.ImageUpdater`
`478`		`-`
`479`	`477`	`obj, errConvert := runtime.DefaultUnstructuredConverter.ToUnstructured(argo)`
`480`	`478`	`if errConvert != nil {`
`481`	`479`	`return fmt.Errorf("failed to convert ArgoCD to unstructured for update: %v", errConvert)`