Fix linter again

Author: mbaldessari

internal/controller/argo.go

@@ -248,10 +248,10 @@ return health_status`,
 		})
 	}
 
-	if customChecksYAML := patternsOperatorConfig.getStringValue("gitops.customHealthChecks"); customChecksYAML != "" {
+	if customChecksYAML := patternsOperatorConfig.getStringValue(configKeyCustomHealthCheck); customChecksYAML != "" {
 		var customChecks []argooperator.ResourceHealthCheck
 		if err := yaml.Unmarshal([]byte(customChecksYAML), &customChecks); err != nil {
-			log.Printf("Failed to parse gitops.customHealthChecks: %v", err)
+			log.Printf("Failed to parse %s: %v", configKeyCustomHealthCheck, err)
 		} else {
 			resourceHealthChecks = append(resourceHealthChecks, customChecks...)
 		}

internal/controller/argo_test.go

@@ -2256,7 +2256,7 @@ var _ = Describe("newArgoCD", func() {
     hs = {}
     hs.status = "Progressing"
     return hs`
-		argo = newArgoCD("test-argo", "test-ns", PatternsOperatorConfig{"gitops.customHealthChecks": customYAML})
+		argo = newArgoCD("test-argo", "test-ns", PatternsOperatorConfig{configKeyCustomHealthCheck: customYAML})
 		Expect(argo.Spec.ResourceHealthChecks).To(HaveLen(4))
 		Expect(argo.Spec.ResourceHealthChecks[0].Kind).To(Equal("PersistentVolumeClaim"))
 		Expect(argo.Spec.ResourceHealthChecks[1].Group).To(Equal("operators.coreos.com"))
@@ -2275,7 +2275,7 @@ var _ = Describe("newArgoCD", func() {
     return hs`
 		argo = newArgoCD("test-argo", "test-ns", PatternsOperatorConfig{
 			"gitops.applicationHealthCheckEnabled": "true",
-			"gitops.customHealthChecks":            customYAML,
+			configKeyCustomHealthCheck:             customYAML,
 		})
 		Expect(argo.Spec.ResourceHealthChecks).To(HaveLen(4))
 		Expect(argo.Spec.ResourceHealthChecks[0].Kind).To(Equal("PersistentVolumeClaim"))
@@ -2285,14 +2285,14 @@ var _ = Describe("newArgoCD", func() {
 	})
 
 	It("should handle invalid YAML in gitops.customHealthChecks gracefully", func() {
-		argo = newArgoCD("test-argo", "test-ns", PatternsOperatorConfig{"gitops.customHealthChecks": "not: valid: yaml: list"})
+		argo = newArgoCD("test-argo", "test-ns", PatternsOperatorConfig{configKeyCustomHealthCheck: "not: valid: yaml: list"})
 		Expect(argo.Spec.ResourceHealthChecks).To(HaveLen(2))
 		Expect(argo.Spec.ResourceHealthChecks[0].Kind).To(Equal("PersistentVolumeClaim"))
 		Expect(argo.Spec.ResourceHealthChecks[1].Group).To(Equal("operators.coreos.com"))
 	})
 
 	It("should not add custom health checks when gitops.customHealthChecks is empty", func() {
-		argo = newArgoCD("test-argo", "test-ns", PatternsOperatorConfig{"gitops.customHealthChecks": ""})
+		argo = newArgoCD("test-argo", "test-ns", PatternsOperatorConfig{configKeyCustomHealthCheck: ""})
 		Expect(argo.Spec.ResourceHealthChecks).To(HaveLen(2))
 	})
 

internal/controller/patterns_operator_config.go

@@ -13,31 +13,32 @@ import (
 type PatternsOperatorConfig map[string]string
 
 const (
-	configKeyCatalogSource    = "gitops.catalogSource"
-	configKeyChannel          = "gitops.channel"
-	configKeySourceNamespace  = "gitops.sourceNamespace"
-	configKeyApprovalPlan     = "gitops.installApprovalPlan"
-	configKeyCSV              = "gitops.csv"
-	configKeyAdditionalAdmins = "gitops.additionalArgoAdmins"
-	configKeyHealthCheck      = "gitops.applicationHealthCheckEnabled"
-	configMapKind             = "ConfigMap"
-	boolTrue                  = "true"
-	boolFalse                 = "false"
+	configKeyCatalogSource     = "gitops.catalogSource"
+	configKeyChannel           = "gitops.channel"
+	configKeySourceNamespace   = "gitops.sourceNamespace"
+	configKeyApprovalPlan      = "gitops.installApprovalPlan"
+	configKeyCSV               = "gitops.csv"
+	configKeyAdditionalAdmins  = "gitops.additionalArgoAdmins"
+	configKeyHealthCheck       = "gitops.applicationHealthCheckEnabled"
+	configKeyCustomHealthCheck = "gitops.customHealthChecks"
+	configMapKind              = "ConfigMap"
+	boolTrue                   = "true"
+	boolFalse                  = "false"
 )
 
 var DefaultPatternsOperatorConfig = PatternsOperatorConfig{
-	configKeyCatalogSource:         GitOpsDefaultCatalogSource,
-	configKeyChannel:               GitOpsDefaultChannel,
-	configKeySourceNamespace:       GitOpsDefaultCatalogSourceNamespace,
-	configKeyApprovalPlan:          GitOpsDefaultApprovalPlan,
-	configKeyCSV:                   GitOpsDefaultCSV,
-	configKeyAdditionalAdmins:      "",
-	configKeyHealthCheck:           boolFalse,
-	"gitops.customHealthChecks":    "",
-	"gitea.chartName":              GiteaChartName,
-	"gitea.helmRepoUrl":            GiteaHelmRepoUrl,
-	"gitea.chartVersion":           GiteaDefaultChartVersion,
-	"catalog.image":                "",
+	configKeyCatalogSource:     GitOpsDefaultCatalogSource,
+	configKeyChannel:           GitOpsDefaultChannel,
+	configKeySourceNamespace:   GitOpsDefaultCatalogSourceNamespace,
+	configKeyApprovalPlan:      GitOpsDefaultApprovalPlan,
+	configKeyCSV:               GitOpsDefaultCSV,
+	configKeyAdditionalAdmins:  "",
+	configKeyHealthCheck:       boolFalse,
+	configKeyCustomHealthCheck: "",
+	"gitea.chartName":          GiteaChartName,
+	"gitea.helmRepoUrl":        GiteaHelmRepoUrl,
+	"gitea.chartVersion":       GiteaDefaultChartVersion,
+	"catalog.image":            "",
 }
 
 func (g PatternsOperatorConfig) getStringValue(k string) string {