Skip to content

Commit c11ded4

Browse files
committed
Fix ineffectual err assignment
1 parent 37a5725 commit c11ded4

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

internal/controller/argo.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -418,9 +418,9 @@ func createOrUpdateArgoCD(client dynamic.Interface, fullClient kubernetes.Interf
418418
newArgo := &unstructured.Unstructured{Object: obj}
419419
_, err = client.Resource(gvr).Namespace(namespace).Create(context.TODO(), newArgo, metav1.CreateOptions{})
420420
} else { // update it
421-
oldArgo, err := getArgoCD(client, name, namespace)
422-
if err != nil {
423-
return fmt.Errorf("failed to get existing ArgoCD %s/%s: %v", namespace, name, err)
421+
oldArgo, errGet := getArgoCD(client, name, namespace)
422+
if errGet != nil {
423+
return fmt.Errorf("failed to get existing ArgoCD %s/%s: %v", namespace, name, errGet)
424424
}
425425
argo.SetResourceVersion(oldArgo.GetResourceVersion())
426426
obj, errConvert := runtime.DefaultUnstructuredConverter.ToUnstructured(argo)

0 commit comments

Comments
 (0)